search

conda-forge / normaliz-feedstock

A conda-smithy repository for normaliz.
BSD 3-Clause "New" or "Revised" License
0 stars 4 forks source link

Upgrade to 3.8.4 #20

Closed saraedum closed 4 years ago

saraedum commented 4 years ago

Fixes #19 Fixes #21

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

saraedum commented 4 years ago

@conda-forge-admin, please rerender

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

saraedum commented 4 years ago

@conda-forge-admin, please rerender

saraedum commented 4 years ago

@isuruf any idea where this one is coming from:

lld-link: warning: ignoring unknown argument '-rpath'
lld-link: error: could not open 'D:/bld/normaliz_1590582882765/_h_env/Library/lib': is a directory
isuruf commented 4 years ago

Here and here

saraedum commented 4 years ago

Output precision has changed in recent versions of e-antic:

diff -b test-nf/2cone.ref test-nf/2cone.out > test-nf/2cone.diff
11c11
< resulting sum of |det|s = (a+2 ~ 3.414214)
---
> resulting sum of |det|s = (a+2 ~ 3.4142136)
19c19
< volume (lattice normalized) = (a+1 ~ 2.414214)
---
> volume (lattice normalized) = (a+1 ~ 2.4142136)
26c26
<  1 (a ~ 1.414214)
---
>  1 (a ~ 1.4142136)
30c30
<  (a ~ 1.414214) -1
---
>  (a ~ 1.4142136) -1
github-actions[bot] commented 4 years ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

Thus the PR was passing and merged! Have a great day!