search

conda-forge / notebook-feedstock

A conda-smithy repository for notebook.
BSD 3-Clause "New" or "Revised" License
3 stars 34 forks source link

Rebuild for pypy #69

Closed regro-cf-autotick-bot closed 4 years ago

regro-cf-autotick-bot commented 4 years ago

This PR has been triggered in an effort to update pypy.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

This package has the following downstream children:

And potentially more.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable. Finally, feel free to drop us a line if there are any issues! This PR was generated by https://circleci.com/gh/regro/circle_worker/24383, please use this URL for debugging

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

bollwyvl commented 4 years ago

the pypy build is still failing... need to dig up the repro script i had to find the missing deps...

isuruf commented 4 years ago

@bollwyvl, can you trigger a build of jupyter_core by pushing an empty commit at https://github.com/conda-forge/jupyter_core-feedstock?

bollwyvl commented 4 years ago

Pushed, drone's building: https://cloud.drone.io/conda-forge/jupyter_core-feedstock/18

bollwyvl commented 4 years ago

Rekicked this build right here: https://cloud.drone.io/conda-forge/notebook-feedstock/25

isuruf commented 4 years ago

@bollwyvl, can you do the same for nbconvert?

github-actions[bot] commented 4 years ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

Thus the PR was passing and merged! Have a great day!

bollwyvl commented 4 years ago

so... i guess this worked? will try it out presently!

bollwyvl commented 4 years ago

Well bless my beard:

Screenshot from 2020-07-06 20-40-27

really amazing stuff!

bollwyvl commented 4 years ago

Here's a gist with a binder link: https://gist.github.com/bollwyvl/b5443c87c58b2e04ac5faba4d62ff232

jakirkham commented 4 years ago

Nicely done! 😄

isuruf commented 4 years ago

Nice. Btw, why do you need a postBuild file?

bollwyvl commented 4 years ago

There's a lot of stuff in the default notebook env, so I'm using postBuild to blow it away and rebuild it. Also, I'm assuming we still need channel_priority: strict? Anyhow, it didn't seem to play nice with updateing the existing 3.7 env.

isuruf commented 4 years ago

Got it. Thanks.

Also, I'm assuming we still need channel_priority: strict?

Yes, but you can add nodefaults which would remove defaults channel.

bollwyvl commented 4 years ago

ah, that's simpler. will update.