conda-forge / nsight-compute-feedstock

A conda-smithy repository for nsight-compute.
BSD 3-Clause "New" or "Revised" License
0 stars 8 forks source link

Is it critical that this depends on qt-main? #15

Open hmaarrfk opened 6 months ago

hmaarrfk commented 6 months ago

It depends on qt-main which is somewhat outdated in 2024. It would help users experiment with qt6 more freely.

It would be good to have:

jakirkham commented 6 months ago

It's worth noting that this is binary repackaging

That said, looking at the logs, see lines like this on CI:

   INFO (nsight-compute,nsight-compute-2024.1.0/host/linux-desktop-glibc_2_11_3-x64/libQt6Test.so.6): Needed DSO nsight-compute-2024.1.0/host/linux-desktop-glibc_2_11_3-x64/libQt6Core.so.6 found in the whitelist
   ...
   INFO (nsight-compute,nsight-compute-2024.1.0/host/linux-desktop-glibc_2_11_3-x64/Plugins/imageformats/libqgif.so): Needed DSO $RPATH/libQt6Core.so.6 found in the whitelist
   ...
   INFO (nsight-compute,nsight-compute-2024.1.0/host/linux-desktop-glibc_2_11_3-x64/Plugins/imageformats/libqtga.so): Needed DSO $RPATH/libQt6Core.so.6 found in the whitelist

So think it should be Qt6 instead of Qt5

hmaarrfk commented 6 months ago

It also seems to pack its own version of qt6....

files like this seem to exist

nsight-compute,nsight-compute-2024.1.0/host/linux-desktop-glibc_2_11_3-x64/libQt6DBus.so.6
jakirkham commented 6 months ago

Yeah looking at the history qt-main was added in PR: https://github.com/conda-forge/nsight-compute-feedstock/pull/7

Appears this was added to fix a test with ncu-ui: https://github.com/conda-forge/nsight-compute-feedstock/pull/7/commits/de9ed4482f82764c9dd2b3f344a6e6e134ceb799

hmaarrfk commented 6 months ago

@conda-forge-admin please rerender

conda-forge-webservices[bot] commented 6 months ago

Hi! This is the friendly automated conda-forge-webservice.

I just wanted to let you know that I started rerendering the recipe in conda-forge/nsight-compute-feedstock#16.