conda-forge / nsight-compute-feedstock

A conda-smithy repository for nsight-compute.
BSD 3-Clause "New" or "Revised" License
0 stars 8 forks source link

Drop unneeded `qt-main` dependency #16

Closed conda-forge-admin closed 6 months ago

conda-forge-admin commented 6 months ago

Hi! This is the friendly automated conda-forge-webservice.

I've started rerendering the recipe as instructed in #15.

If I find any needed changes to the recipe, I'll push them to this PR shortly. Thank you for waiting!

Here's a checklist to do before merging.

conda-forge-webservices[bot] commented 6 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

hmaarrfk commented 6 months ago

@conda-forge-admin please rerender

jakirkham commented 6 months ago

Thanks Mark! 🙏

Let's drop the commented line and bump the build/number

hmaarrfk commented 6 months ago

Given thi sis a build tool, do we need to backport too to older versions?

jakirkham commented 6 months ago

We could add a repodata patch to drop the dependency in old versions. Assuming tests pass for those with this change

Though am a little confused by the build dependency statement. Could you please share a bit more on that?

hmaarrfk commented 6 months ago

I just mean that people are more likely to hit this problem when building software since nsight-compute gets dragged in when you install the cuda-toolkit but not when you install the runtime dependencies.

jakirkham commented 6 months ago

Sorry if this is obvious. Just want to make sure we are on the same page

For clarity cudatoolkit and cuda-toolkit are two very different things:

If we are seeing cuda-toolkit pulled in by builds somewhere, that is likely a bug, which we should look into

Please ask questions on this if you have any

hmaarrfk commented 6 months ago

For clarity cudatoolkit and cuda-toolkit are two very different things:

haha, this was not clear to me. and explains my confusion.

jakirkham commented 6 months ago

No worries. Completely understand why it is confusing

The naming was picked to align more closely with other distros that also use cuda-toolkit

However we already have cudatoolkit in Conda that means something different for historical reasons, which understandably causes confusion given the similar names

We tried to align these differences with a major version bump ( 11 / 12 ) to help clarify the breaking change and drop cudatoolkit as part of that

Tried to cover this in the 2023 SciPy talk as well

If there are other ways, we can make this clearer please let us know

jakirkham commented 6 months ago

Thanks Mark and Alex! 🙏