conda-forge / nsis-feedstock

A conda-smithy repository for nsis.
BSD 3-Clause "New" or "Revised" License
0 stars 10 forks source link

Bump to 3.06.1 and add unix #19

Closed isuruf closed 4 years ago

isuruf commented 4 years ago

Checklist

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

isuruf commented 4 years ago

@conda-forge-admin, rerender

isuruf commented 4 years ago

@conda-forge-admin, rerender

isuruf commented 4 years ago

@conda-forge/nsis, this is ready.

jakirkham commented 4 years ago

Do you have a use case for this on UNIX? My understanding is this is primarily used to create installers on Windows.

isuruf commented 4 years ago

You can create installers for windows from unix.

mbargull commented 4 years ago

@isuruf, thanks for the update and Unix addition and also for finally modernizing this to the conda-build+libarchive era!

mbargull commented 4 years ago

Linux build fails because it says the patch could not be applied. Either the line endings are incorrectly checked out in the CI or it's maybe a bug in conda-build>=3.20. Locally the build with conda-build=3.19.2 works fine and the line endings in the repository https://raw.githubusercontent.com/conda-forge/nsis-feedstock/8958bc2b1ac42279d1950b2e47980c52020db260/recipe/0001-Always-use-relative-paths-for-CONF-and-DATA-directories.patch are also correct.

mbargull commented 4 years ago

or it's maybe a bug in conda-build>=3.20.

Yep, updating to conda-build=3.20.2 breaks the build locally.

mbargull commented 4 years ago

or it's maybe a bug in conda-build>=3.20.

Yep, updating to conda-build=3.20.2 breaks the build locally.

So, not a bug, actually. The line endings were correct, but I unintentionally replaced tabs with spaces in the patch :facepalm:.

mbargull commented 4 years ago

@isuruf, do the changes I added look okay to you?

isuruf commented 4 years ago

Looks good to me. Thanks for the updates

mbargull commented 4 years ago

And thanks to you!