Closed isuruf closed 4 years ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
@conda-forge-admin, rerender
@conda-forge-admin, rerender
@conda-forge/nsis, this is ready.
Do you have a use case for this on UNIX? My understanding is this is primarily used to create installers on Windows.
You can create installers for windows from unix.
@isuruf, thanks for the update and Unix addition and also for finally modernizing this to the conda-build
+libarchive
era!
Linux build fails because it says the patch could not be applied.
Either the line endings are incorrectly checked out in the CI or it's maybe a bug in conda-build>=3.20
.
Locally the build with conda-build=3.19.2
works fine and the line endings in the repository https://raw.githubusercontent.com/conda-forge/nsis-feedstock/8958bc2b1ac42279d1950b2e47980c52020db260/recipe/0001-Always-use-relative-paths-for-CONF-and-DATA-directories.patch are also correct.
or it's maybe a bug in
conda-build>=3.20
.
Yep, updating to conda-build=3.20.2
breaks the build locally.
or it's maybe a bug in
conda-build>=3.20
.Yep, updating to
conda-build=3.20.2
breaks the build locally.
So, not a bug, actually. The line endings were correct, but I unintentionally replaced tabs with spaces in the patch :facepalm:.
@isuruf, do the changes I added look okay to you?
Looks good to me. Thanks for the updates
And thanks to you!
Checklist
0
(if the version changed)conda-smithy
(Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)