Add logging builds (from special builds)

conda-forge / nsis-feedstock

A conda-smithy repository for nsis.

BSD 3-Clause "New" or "Revised" License

0 stars 10 forks source link

Add logging builds (from special builds) #21

Closed jaimergp closed 1 year ago

jaimergp commented 2 years ago

Checklist

[X] Used a personal fork of the feedstock to propose changes
[X] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[X] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[X] Ensured the license file is being packaged.

Logging builds are useful for debugging. See https://nsis.sourceforge.io/Special_Builds. I am also adding myself as a maintainer.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

dbast commented 1 year ago

Logging builds are e.g. used in the constructor tests for debugging.

The manual download from sourceforge there is not really reliable. Having it as conda package would improve that situation.

@conda-forge/nsis ready for review. thanks

jaimergp commented 1 year ago

A week has passed with no answer. I am merging!

jaimergp commented 1 year ago

@conda-forge-admin, please rerender

github-actions[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/nsis-feedstock/actions/runs/4014391339.

jakirkham commented 1 year ago

@jaimergp, there were issues identified by @isuruf in the last PR that are not addressed. Think those should be handled before merging new things. Have raised an issue to track this ( https://github.com/conda-forge/nsis-feedstock/issues/23 )