search

conda-forge / nsis-feedstock

A conda-smithy repository for nsis.
BSD 3-Clause "New" or "Revised" License
0 stars 10 forks source link

Use stable links #23

Closed jakirkham closed 1 year ago

jakirkham commented 1 year ago

Currently the links seem to be changing here. We need to pick something that is static

https://github.com/conda-forge/nsis-feedstock/pull/20#discussion_r1085400238

https://github.com/conda-forge/nsis-feedstock/pull/20#discussion_r1085400395

cc @isuruf

jaimergp commented 1 year ago

Hm, I had not seen those comments, sorry! I'll address them next week.

jakirkham commented 1 year ago

No worries. Thanks for following up 🙏

jakirkham commented 1 year ago

We could just upload those on a (date-based?) tag on this repo

jakirkham commented 1 year ago

@jezdez , appears Anaconda has the same issue with this recipe. Maybe we can coordinate on the solution here?

jaimergp commented 1 year ago

Given how important NSIS is for the installers, maybe something like conda/nsis-mirror which the community can control (instead of personal repos), would be super welcome?

jakirkham commented 1 year ago

In the past we've just attached this sort of thing to the feedstock directly. We can always add maintainers. It's a pretty lightweight solution

That said, don't have strong feelings. @isuruf , what do you think?

jezdez commented 1 year ago

@jezdez , appears Anaconda has the same issue with this recipe. Maybe we can coordinate on the solution here?

Yeah, that's a good idea, I've filed an internal ticket about this so that @skupr-anaconda and others can take a look.

jezdez commented 1 year ago

For the record, the recipe for nsis lives (IIUC) here: https://github.com/AnacondaRecipes/aggregate/blob/master/nsis-feedstock/recipe/meta.yaml

dbast commented 1 year ago

why not use a repo in one of the Github orgs (conda-forge/conda/conda-incubator/AnacondaRecipes), uploads and changes can then be done via PRs... I am not aware of an internal Anaconda WebService that allows binary uploads via PR so that uploads and its operation are transparent to everybody.

jaimergp commented 1 year ago

We basically need something like https://github.com/kichik/nsis but with synced Releases (not just tags) that bundle the binary artifacts, and all the plugins.

jaimergp commented 1 year ago

I added some logic in a fork of that repo. We can transfer it to conda-incubator or similar once we are happy with it.

jaimergp commented 1 year ago

The mirror is now ready, and a PR is ready for review: https://github.com/conda-forge/nsis-feedstock/pull/24

Thanks!