search

conda-forge / nsis-feedstock

A conda-smithy repository for nsis.
BSD 3-Clause "New" or "Revised" License
0 stars 10 forks source link

Release 3.01 #7

Closed jakirkham closed 6 years ago

jakirkham commented 6 years ago

Fixes https://github.com/conda-forge/nsis-feedstock/issues/6

Releases nsis 3.01 (needed by recent versions of constructor ( https://github.com/conda-forge/constructor-feedstock/pull/8 )) and re-renders with conda-smithy 2.4.2.

conda-forge-linter commented 6 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

mbargull commented 6 years ago

FYI: in ContinuumIO/anaconda-recipes they manually copy in some other files -- I don't know the reasons for that, though. See: https://github.com/ContinuumIO/anaconda-recipes/blob/812533940b05f36ce0d2e108e36a874dc532f6cc/nsis/add_deps.py

jakirkham commented 6 years ago

Yeah, we do too. We just use robocopy instead.

One day we should try to build this from source. ( https://github.com/conda-forge/nsis-feedstock/issues/1 ) Unfortunately that is not today.

mbargull commented 6 years ago

That was not what I meant. I should have emphasized "some other files". Apparently the nsis package in the free-repository gets augmented with some plugins. In the sources I linked to you'll see:

    'c71733d8ef33afcc99050ba2b0c56614 UAC.dll',
    '832c58ba1567ab9dec35e115f0b50e8f untgz.dll',
    '7178d69ded53b7683dd52cd1ca0a20ff elevate.exe',
    'be71dfd1419eb91778cfde6bb8a44320 UnicodePathTest.dll'

being copied to $PREFIX/NSIS/Plugins/x86-unicode.

I'm not sure that is a good thing, but nonetheless this could mean that constructor needs some additional dependency / package that provides those plugins if conda-forge does not include them.

mbargull commented 6 years ago

Ah, of course constructor uses them, see for example: https://github.com/conda/constructor/issues/59.

jakirkham commented 6 years ago

I see. Sorry for missing the point. Think PR ( https://github.com/conda-forge/nsis-feedstock/pull/9 ) should address this. Please take a look and let me know your thoughts.

jakirkham commented 6 years ago

Have moved the packages produced by this PR under the broken label on Anaconda due to needed Unicode bits being absent.