search

conda-forge / nsis-feedstock

A conda-smithy repository for nsis.
BSD 3-Clause "New" or "Revised" License
0 stars 10 forks source link

Add extra unicode bits #9

Closed jakirkham closed 6 years ago

jakirkham commented 6 years ago

Adds in some extra unicode bits that Anaconda seems to be including in their nsis package for use with constructor.

cc @mbargull

conda-forge-linter commented 6 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

jakirkham commented 6 years ago

So managed to pull most of the listed files that Anaconda Recipes includes from plugins using a custom Python script. However was unable to find where elevate.exe comes from and thus how to get it and add it. Any advice on this front would be greatly appreciated.

mbargull commented 6 years ago

Hi @jakirkham, sorry for the late reply. I started to look into it yesterday and already wrote a script for that but didn't test it yet. Should've informed you to avoid duplicate work, sorry. I'll come back to you in a couple of minutes.

mbargull commented 6 years ago

Sorry again, I was distracted.. I opened a PR for your branch at https://github.com/jakirkham-feedstocks/nsis-feedstock/pull/1. For the Anaconda recipe they used some specific or altered versions of those plugins. My updates to the recipe ensure that we use exactly those.

mbargull commented 6 years ago

That elevate.exe binary apparently comes from http://code.kliu.org/misc/elevate/ but I just couldn't find any license information for it :/ ... That's a little disappointing. Furthermore it is packaged inside a .7z archive such that I had to include 7za as a build dependency. Note that 7-Zip is not available on conda-forge.

jakirkham commented 6 years ago

@conda-forge-admin, please rerender.

jakirkham commented 6 years ago

Looks like this is green now. Any last thoughts before merging?

mbargull commented 6 years ago

Only this one: 🍻

jakirkham commented 6 years ago

In it goes. Thanks so much for your help. 😄

jakirkham commented 6 years ago

Packages just now released! 🍾 🎉

jakirkham commented 6 years ago

Not sure if this would be interesting to you or not, but I have been working on a conda installer for conda-forge provisionally named miniforge. Am hoping to migrate it to conda-forge once its more prime time ready. There are a couple Windows things that I could certainly use some help on if you have time.