conda-forge / numba-feedstock

A conda-smithy repository for numba.

BSD 3-Clause "New" or "Revised" License

0 stars 27 forks source link

Pin setuptools<60 #104

Closed xhochy closed 2 years ago

xhochy commented 2 years ago

See https://github.com/numba/numba/commit/454fe25b0f0ebf0e85e7dc1fa8a6fab50157adcd

This fixes all the failing pip check calls in downstream packages.

Related discussion in yesterday

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

henryiii commented 2 years ago

Upstream is planning on removing this dependency as required (and that forces it to be unlimited). I think the best action is to patch out the limit here.

jakirkham commented 2 years ago

If we want to add to host and test/requires, that seems ok. Based on discussion starting here ( https://github.com/conda-forge/numba-feedstock/pull/94#discussion_r982039697 ), we've decided not to do this in run as it would cause different kinds of user pain

As Henry already noted, upstream is working to eliminate this dependency

henryiii commented 2 years ago

But host and test/requires doesn't affect downstream users, it would not fix the pip check issues. And Numba does support newer setuptools except for 65.0.0 and 65.0.1 due to the removal of msvccompiler that was reverted later. So there's no harm in this, but no benefit either.

105 fixes pip check to show the issue. I believe the correct fix (building on that one) would be to patch setup.py to remove this limit. Upstream plans to remove this as a requirement, which means it can't be constrained anymore from their end (since pip doesn't have optional constraints).

gmarkall commented 2 years ago

I believe the correct fix (building on that one) would be to patch setup.py to remove this limit.

An attempt at this is in #106.