Remove tbb constraints - Githubissues

conda-forge / numba-feedstock

A conda-smithy repository for numba.

BSD 3-Clause "New" or "Revised" License

0 stars 27 forks source link

Closed ekomarova closed 1 year ago

ekomarova commented 1 year ago

This patch allows to remove the restriction on using tbb <2021.6 and build numba with tbb >2021.6

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

ekomarova commented 1 year ago

@henryiii @jakirkham @marcelotrevisani @mbargull @souravsingh @step21 Please review

jakirkham commented 1 year ago

Sorry for missing this 😞

The constraint comes from upstream (where it has likely seen more testing). So think we should stick with that version

That said, this should be fixed in numba version 0.57.0 where the constraint was loosened. Including a similar change in PR ( https://github.com/conda-forge/numba-feedstock/pull/115 ), which should address this need