I think numpy 1.16 is now supported

conda-forge / numba-feedstock

A conda-smithy repository for numba.

BSD 3-Clause "New" or "Revised" License

0 stars 27 forks source link

Closed hmaarrfk closed 5 years ago

hmaarrfk commented 5 years ago

I think it is supported

Checklist

[ ] Used a fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

hmaarrfk commented 5 years ago

@conda-forge-admin, please rerender

jakirkham commented 5 years ago

I think we just want to drop that pinning altogether. It was added as a workaround. Please see PR ( https://github.com/conda-forge/numba-feedstock/pull/23 ) for details.

hmaarrfk commented 5 years ago

I pinned the host dependency so as to avoid any default pinnings there. Is that not correct?

jakirkham commented 5 years ago

Yes, numpy should not be pinned in host.

hmaarrfk commented 5 years ago

lets monitor to see what it compiles with.

jakirkham commented 5 years ago

We might need to re-render.

hmaarrfk commented 5 years ago

@conda-forge-admin, please rerender

hmaarrfk commented 5 years ago

I'm not sure if numba deals well with such old numpy. Numpy 1.9 seems to have been pinned. lets check the builds when they finish though

jakirkham commented 5 years ago

Thanks @hmaarrfk :)

jakirkham commented 5 years ago

FWIW it looks like they are testing against NumPy 1.9.