search

conda-forge / numba-feedstock

A conda-smithy repository for numba.
BSD 3-Clause "New" or "Revised" License
0 stars 27 forks source link

0.50.1 #50

Closed crusaderky closed 4 years ago

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

crusaderky commented 4 years ago

@conda-forge-admin please rerender

github-actions[bot] commented 4 years ago

Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do.

marcelotrevisani commented 4 years ago

we still don't have llvmlite 0.33.0 related to https://github.com/conda-forge/llvmlite-feedstock/pull/32

jakirkham commented 4 years ago

Thanks @crusaderky! Unfortunately we are still blocked by llvmlite version 0.33.0 builds on Windows ( https://github.com/conda-forge/llvmlite-feedstock/pull/32 ). Without that, we won't be able to upgrade. If you are able to help with the Windows builds, that would be great! 😄

jakirkham commented 4 years ago

Sorry @marcelotrevisani. Seems we posted at that the same time 😉

marcelotrevisani commented 4 years ago

Sorry @marcelotrevisani. Seems we posted at that the same time wink

:smile: haha, no worries! :grin:

crusaderky commented 4 years ago

@jakirkham would it be possible to skip the windows build for now and then repackage once it becomes available?

crusaderky commented 4 years ago

Also, the CI build is now using llvmlite from the pkgs/main repo. Do we need to use llvmlite from conda-forge?

jakirkham commented 4 years ago

defaults and conda-forge are likely building these in fairly different ways (though I could be wrong). This is tied to how LLVM packaging is done in both channels.

It would be nice to have all the platforms covered.

marcelotrevisani commented 4 years ago

Let's wait for the llvmlite 0.33.0 I am optimistic that we are getting close to build that on windows :)

step21 commented 4 years ago

Hey, so as llvmlite was for now merged without windows - would it be ok to do that here too? Mainly as it seems that there is an error about TypeError / jitdebug which yielded only two results in projects using numba, which claimed downgrading llvmlite or using numba 0.49.1 fixed it, which does not apply here. Zero results at numba gibthub issues. And when using 0.50.1 it seems to work. (tested locally and here https://github.com/conda-forge/numba-feedstock/pull/52) (and linux etc failed because I forgot to change llvm version for them like you did above, so disregard that please)

jakirkham commented 4 years ago

Well we only disabled Python 3.8 on Windows. Other Python and Windows combinations are still built. That said, sure I suppose we can do something similar here.

isuruf commented 4 years ago

This PR works fine now and is ready to be merged. (llvmlite 0.33 for win py38 is coming from defaults)