search

conda-forge / numba-feedstock

A conda-smithy repository for numba.
BSD 3-Clause "New" or "Revised" License
0 stars 27 forks source link

numba v0.54.0 #83

Closed regro-cf-autotick-bot closed 3 years ago

regro-cf-autotick-bot commented 3 years ago

It is very likely that the current package version for this feedstock is out of date. Notes for merging this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version. Checklist before merging this PR:
    • [ ] Dependencies have been updated if changed: see upstream
    • [ ] Tests have passed
    • [ ] Updated license if changed and license_file is packaged

Note that the bot will stop issuing PRs if more than 3 Version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.

NEW: If you want these PRs to be merged automatically, make an issue with code>@conda-forge-admin,</codeplease add bot automerge in the title and merge the resulting PR. This command will add our new bot automerge feature to your feedstock!

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable. Finally, feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/1148067475, please use this URL for debugging

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: false to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis of the source code shows a discrepancy between the library's imports and the package's stated requirements in the meta.yaml.

Packages found by inspection but not in the meta.yaml:

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

henryiii commented 3 years ago

Now just need to wait for llvmlite to release.

jakirkham commented 3 years ago

Showed up on PyPI ~1hr ago so migrator PR should be soon

henryiii commented 3 years ago

https://github.com/conda-forge/llvmlite-feedstock/pull/55

jakirkham commented 3 years ago

@conda-forge-admin, please restart CI

jakirkham commented 3 years ago

@conda-forge-admin, please re-render

github-actions[bot] commented 3 years ago

Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do.

jakirkham commented 3 years ago

@conda-forge-admin, please re-render

jakirkham commented 3 years ago

From CI:

conda.exceptions.ResolvePackageNotFound: 
  - numpy[version='<1.19,>=1.21.2,<2.0a0']
conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

henryiii commented 3 years ago 
raise ImportError("Numba needs NumPy 1.20 or less")

That's a pretty clear limit. I'll add a limit when I get back unless some beats me to it or I can do it from my phone.

henryiii commented 3 years ago

Do we know that package is setting numpy[version='<1.19,>=1.21.2,<2.0a0'] That might be a problem on Python 3.9, which collides with the supported NumPy's.

Seems to me it’s not building with the minimum. Wonder if I broke that with the build minimum.

henryiii commented 3 years ago

@conda-forge-admin, please re-render

github-actions[bot] commented 3 years ago

Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do.

henryiii commented 3 years ago

Why am I only seeing linux_ppc64le (travis) and linux_aarch54 (drone)? Hmm, anyway, Python 3.9 is failing with:

"/drone/src/build_artifacts/numba_1629645725199/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/lib/python3.9/site-packages/numba/core/pythonapi.py", line 12, in <module>
1202s
3174        from numba import _helperlib
1202s
3175    ImportError: /drone/src/build_artifacts/numba_1629645725199/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/lib/python3.9/site-packages/numba/_helperlib.cpython-39-aarch64-linux-gnu.so: undefined symbol: pthread_atfork

The other two versions of Python are fine.

Maybe numba's build system is assuming there's a -lpthreads from distutils, but there isn't? https://github.com/scipy/scipy/issues/11323 looks similar.

jakirkham commented 3 years ago

Looks like this was addressed relatively recently upstream (though after the release) with PR ( https://github.com/numba/numba/pull/7312 ). Have gone ahead and included that patch and applied it above. Let's see how that does 🙂

jakirkham commented 3 years ago

Why am I only seeing linux_ppc64le (travis) and linux_aarch54 (drone)?

Please see this issue ( https://github.com/conda-forge/status/issues/117 )

Edit: The last build can be seen here: https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=366645&view=results

jakirkham commented 3 years ago

Looks like that fixed some of the jobs, but curiously one of the ARM jobs still fails.

@stuartarchibald would you be able to help us out here? 🙂 No worries if not. Just kind of stumped

henryiii commented 3 years ago

I just found out about this from @tdegeus on a different feedstock.

The "fix" in numba upstream seems incomplete, it's not just Aarch64. I think it needs to be activated for Python 3.9(.5?)(+?).

jakirkham commented 3 years ago

Right it's been added to all Linux jobs. Please see this comment ( https://github.com/conda-forge/numba-feedstock/pull/83#pullrequestreview-735697875 ). It does seem to fix PPC, but not ARM. The x86 jobs on Azure look ok as well.

jakirkham commented 3 years ago

FYI Azure jobs statuses seem to be showing up 😄

jakirkham commented 3 years ago

@stuartarchibald, would you be able to help advise us here? 🙂 If not, no worries

For context, we seem to be running into the pthread_atfork issue seen upstream, we applied the same solution to attempt to fix it. This worked everywhere except for ARM. Kind of stumped as to what we are missing here. Please let us know if you spot anything.

chrisburr commented 3 years ago

@conda-forge/numba I think this is ready to mereg

henryiii commented 3 years ago

Thanks! We should make sure upstream is aware of the issue as well, since it wasn't fully solved there.

stuartarchibald commented 3 years ago

@stuartarchibald, would you be able to help advise us here? slightly_smiling_face If not, no worries

For context, we seem to be running into the pthread_atfork issue seen upstream, we applied the same solution to attempt to fix it. This worked everywhere except for ARM. Kind of stumped as to what we are missing here. Please let us know if you spot anything.

@jakirkham apologies for the slow reply, is this now fixed?

jakirkham commented 3 years ago

I think @chrisburr worked around it above in commit ( https://github.com/conda-forge/numba-feedstock/pull/83/commits/d44d676be3f3d4f176cde26008bc81de30298695 ) by passing the same flag in the test phase

stuartarchibald commented 3 years ago

I think @chrisburr worked around it above in commit ( d44d676 ) by passing the same flag in the test phase

Great, thanks for confirming!

henryiii commented 3 years ago

In Numba, the addition of the pthread flag should happen in more architectures (probably depended on Python version, 3.9.5 is the first buggy one, IIUC), and it should happen in such a way that it's not needed in the test phase (either by being added by the tests, or being added wherever it's coming from in the build infrastructure).