conda-forge / numba-feedstock

A conda-smithy repository for numba.
BSD 3-Clause "New" or "Revised" License
0 stars 27 forks source link

numba v0.55.1 #88

Closed regro-cf-autotick-bot closed 2 years ago

regro-cf-autotick-bot commented 2 years ago

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with code>@conda-forge-admin,</codeplease add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: false to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis of the source code shows a discrepancy between the library's imports and the package's stated requirements in the meta.yaml.

Packages found by inspection but not in the meta.yaml:

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/1757853548, please use this URL for debugging.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

henryiii commented 2 years ago

No GitHub release yet, so here's the diff, with the changelog: https://github.com/numba/numba/compare/0.55.0...0.55.1

jakirkham commented 2 years ago

No GitHub release yet

That appears to be an unticked box in issue ( https://github.com/numba/numba/issues/7781 ), which is still open. So presumably they will get to that soon

jakirkham commented 2 years ago

Seeing this error on ARM (it is the only error/failure that is unexpected):

======================================================================
ERROR: test_TestParforNumPy (numba.tests.test_parfors.TestParforsRunner)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/conda/feedstock_root/build_artifacts/numba_1643310780204/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/lib/python3.10/site-packages/numba/tests/test_parfors.py", line 88, in test_TestParforNumPy
    self.runner()
  File "/home/conda/feedstock_root/build_artifacts/numba_1643310780204/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/lib/python3.10/site-packages/numba/tests/test_parfors.py", line 77, in runner
    self.subprocess_test_runner(test_module=themod,
  File "/home/conda/feedstock_root/build_artifacts/numba_1643310780204/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/lib/python3.10/site-packages/numba/tests/support.py", line 559, in subprocess_test_runner
    status = subprocess.run(cmd, stdout=subprocess.PIPE,
  File "/home/conda/feedstock_root/build_artifacts/numba_1643310780204/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/lib/python3.10/subprocess.py", line 503, in run
    stdout, stderr = process.communicate(input, timeout=timeout)
  File "/home/conda/feedstock_root/build_artifacts/numba_1643310780204/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/lib/python3.10/subprocess.py", line 1149, in communicate
    stdout, stderr = self._communicate(input, endtime, timeout)
  File "/home/conda/feedstock_root/build_artifacts/numba_1643310780204/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/lib/python3.10/subprocess.py", line 2001, in _communicate
    self._check_timeout(endtime, orig_timeout, stdout, stderr)
  File "/home/conda/feedstock_root/build_artifacts/numba_1643310780204/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/lib/python3.10/subprocess.py", line 1193, in _check_timeout
    raise TimeoutExpired(
subprocess.TimeoutExpired: Command '['/home/conda/feedstock_root/build_artifacts/numba_1643310780204/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/bin/python', '-m', 'numba.runtests', 'numba.tests.test_parfors.TestParforNumPy']' timed out after 1800 seconds

----------------------------------------------------------------------
henryiii commented 2 years ago

Maybe this needs updating? If there are more or slower tests. Would be good to compare with out close we were to the edge before, but I think we were pretty close.

https://github.com/conda-forge/numba-feedstock/blob/96944ecd0990c08d2d92e33e3d4c220c33b3cf17/recipe/run_test.sh#L42

esc commented 2 years ago

No GitHub release yet

That appears to be an unticked box in issue ( numba/numba#7781 ), which is still open. So presumably they will get to that soon

We don't make GitHub releases AFAICT

henryiii commented 2 years ago
Screen Shot 2022-01-27 at 5 11 50 PM

It's just nice to see the current release when visiting the page, plus it notifies release watchers.

esc commented 2 years ago

No GitHub release yet

That appears to be an unticked box in issue ( numba/numba#7781 ), which is still open. So presumably they will get to that soon

We don't make GitHub releases AFAICT

Oh, my bad, this is done post-release.

henryiii commented 2 years ago

Any idea about the slow test? It's consistently too slow now. Was that expected?

henryiii commented 2 years ago

I do see a few new tests, so let's try scaling back the fraction a bit on ARM.

jakirkham commented 2 years ago

Looks like we are seeing the same error ( https://github.com/conda-forge/numba-feedstock/pull/88#issuecomment-1023674154 )

cc @stuartarchibald (in case you have any thought here 🙂)

stuartarchibald commented 2 years ago

@jakirkham

Looks like we are seeing the same error ( #88 (comment) )

cc @stuartarchibald (in case you have any thought here slightly_smiling_face)

There's obvious no change between 0.55.0 and 0.55.1 that I can see that would make those tests run more slowly, which makes this a bit puzzling. Perhaps it was very near the threshold as @henryiii noted. The timeout is here if patching it is an option: https://github.com/numba/numba/blob/release0.55/numba/tests/test_parfors.py#L66

stuartarchibald commented 2 years ago

@henryiii

Maybe this needs updating? If there are more or slower tests

The tests that are failing are "bulk" runs of unit tests, they are run together in subprocesses to reduce memory pressure, from the logs it looks like it's this 30 minute timeout on running the bulk test(s) that's causing the failure. Obviously no use to this problem, but I've an idea of how to avoid this via another means, that I'll try later today.

jakirkham commented 2 years ago

Maybe this is just oversubscription? Wondering if we should just use fewer threads on ARM when running tests

stuartarchibald commented 2 years ago

Maybe this is just oversubscription? Wondering if we should just use fewer threads on ARM when running tests

It may well be. It looks like there was a restriction applied here (it's now commented): https://github.com/conda-forge/numba-feedstock/blob/676106d06c03d7c5e11d9fdfdbb3bc73693d5492/recipe/run_test.sh#L24-L25

I'd also be interested in knowing what happens if the timeout on that set of tests is set to something much bigger, am wondering if the tests eventually complete or if they are stuck (this line sets the time out: https://github.com/numba/numba/blob/release0.55/numba/tests/test_parfors.py#L66).

jakirkham commented 2 years ago

Looks like bumping the timeout worked 🎉

Thanks for pushing on this Henry! 😄

stuartarchibald commented 2 years ago

Looks like bumping the timeout worked tada

Thanks for pushing on this Henry! smile

Many thanks for trying this @henryiii, I've added https://github.com/numba/numba/pull/7813 to make sure it ends up in mainline for 0.56 such that the patch won't need to be carried beyond this release.

jakirkham commented 2 years ago

With Stuart's review comments addressed, have added the automerge label as it sounds like we are good to merge/build/upload packages. Though if I've missed anything, feel free to remove that label.

henryiii commented 2 years ago

The patch should automatically conflict once 0.56 is out, reminding us to drop it, so good to go from my side.

github-actions[bot] commented 2 years ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

Thus the PR was passing and merged! Have a great day!

stuartarchibald commented 2 years ago

Thanks for your efforts on this @henryiii @jakirkham, great to see 0.55.1 built.

jakirkham commented 2 years ago

Thanks for your help Stuart! 😀

stuartarchibald commented 2 years ago

Thanks for your help Stuart! grinning

No problem, glad all the issues were resolved!