Closed ericpre closed 11 months ago
conda-forge-webservices[bot]
commented
11 months ago Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.
ericpre
commented
11 months ago @conda-forge-admin, please rerender
ericpre
commented
11 months ago ~For some reason, there was something wrong with with the rerender in https://github.com/conda-forge/numexpr-feedstock/pull/56 (even after the bot rerender in https://github.com/conda-forge/numexpr-feedstock/pull/56/commits/8e431f3e9bb3fc4deb4e24892a5ebf886160ea43) and mkl was still set to 2022 for linux build but was correctly updated to 2023 on windows...~
~The rerender in https://github.com/conda-forge/numexpr-feedstock/pull/58/commits/85a89da03f5ebba02986b0659e631732e499cd25 seems to work as expected as the mkl version in the relevant .ci_support is updated correctly.~
Edit: this is incorrect: the correct explanations are:
mkl and mkl-devel versions are specified in this recipe on windows only: there are therefore set correctly on windows!mkl 2023 in https://github.com/conda-forge/conda-forge-pinning-feedstock/pull/5129, there is a mismatch between mkl and mkl-devel which make the linux builds failericpre
commented
11 months ago @conda-forge-admin, please rerender
ericpre
commented
11 months ago This PR shows that the recipe build fine using mkl 2023 and we just need the pin to be fixed.
After https://github.com/conda-forge/conda-forge-pinning-feedstock/pull/5289 is merged, we should remove the mkl and mkl_devel pin from this recipe to use the global pinning - the mkl pin on windows are necessary anymore.
ericpre
commented
11 months ago Closing as https://github.com/conda-forge/conda-forge-pinning-feedstock/pull/5289 and #59 have been merged.
Checklist
0(if the version changed)conda-smithy(Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)