conda-forge / nvcc-feedstock

A conda-smithy repository for nvcc.
BSD 3-Clause "New" or "Revised" License
12 stars 23 forks source link

Use `return` in activate/deactivate scripts #24

Closed jakirkham closed 5 years ago

jakirkham commented 5 years ago

Partially addresses https://github.com/conda-forge/nvcc-feedstock/issues/22

With scripts that are being sourced, it is recommended to use return instead of exit. This ensure the sourced script errors out without accidently exiting from a user session as well.

cc @pearu

Checklist

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

jakirkham commented 5 years ago

FWIW also tried this myself locally and it had the right error handling behavior.