Closed jaimergp closed 3 years ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
This passes locally but the CLI installation of CUDA doesn't modify PATH or sets CUDA_PATH. I'll look into it tomorrow!
Looks like it's working. I have updated the PR description with comments and questions.
I think I was a bit too quick to push the new commits. The new conda-forge-ci-setup
is not deployed yet 😬
I guess CUDA 11 places their Windows files elsewhere. I'll investigate locally.
That did it. CUDA 11 does not ship a %CUDA_HOME%\version.txt
file, so I am querying %CUDA_HOME%\bin\nvcc.exe --version
for release %PKG_VERSION%
as a fallback mechanism.
Anything else needed?
Thanks! 🥳
Thanks for all of this work! 😄
Checklist
0
(if the version changed)conda-smithy
(Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)Bringing CUDA to Windows
We need three things
cudatoolkit
packages (submitted by @scopatz)nvcc
metapackage (this PR)conda-forge-ci-setup
-- see https://github.com/conda-forge/conda-forge-ci-setup-feedstock/pull/129conda-forge-pinning
-- see https://github.com/conda-forge/conda-forge-pinning-feedstock/pull/914Questions:
cuda.lib
fromCUDA_HOME\lib\x64
toLIBRARY_LIB
. Is this ok?CUDA_PATH
, notCUDA_HOME
, but I am aliasing this one just in case.cuda-gdb
so I am usingnvcc
as a fallback pathfindervs2015
, which is now deprecated in conda-forge. There could be a workaround, but looks tricky.