[Windows] Export CFLAGS and friends with quoted paths

jaimergp commented 3 years ago

Checklist

[X] Used a personal fork of the feedstock to propose changes
[X] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[X] Ensured the license file is being packaged.

Trying to fix https://github.com/conda-forge/faiss-split-feedstock/pull/19#issuecomment-743106403

We'll probably need to add more tests here to cover these cases, because this wasn't caught earlier :/

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

jakirkham commented 3 years ago

Thanks for looking into this Jaime! 😄

Unfortunately it appears we are getting build failures on Windows as well. Maybe related to the comment above?

jaimergp commented 3 years ago

Seems like the change does indeed quote the path (this is what we need, I think), but that messes up the tests because quotes in quotes is a nono in batch. I'll have to come up with a different way to test it then...

h-vetinari commented 3 years ago

Not sure which tests are failing, but just wanted to throw in (probably you know already?) that if you want to get rid of quotes at variable insertion time, you could use %MY_VAR%:"=%

jaimergp commented 3 years ago

I'll leave it here for today. At some point batch just becomes a set of little puzzles 🥳 /sarcasm

jaimergp commented 3 years ago

After some local debugging, turns out it was easier than whatever I was trying to do.

Since unsetting a variable in cmd involves set "VARIABLE=", we don't need to test for the backup variable existence: if it has a value it will be set to that; if not it will be functionally unset.

I have also enabled @echo on on the activation script.

A question remains though: do we really need CFLAGS on Windows? I guess it's only for the GCC compilers (msys2?) but is that even supported with CUDA? Also, what about INCLUDE and friends for MSVC? Should I be setting something else?

h-vetinari commented 3 years ago

Thanks @jaimergp!

I would like to give this PR a whirl in conda-forge/faiss-split-feedstock#19, so I'd prefer if we can defer the question about CFLAGS for afterwards. :)

isuruf commented 3 years ago

A question remains though: do we really need CFLAGS on Windows?

Only CMake uses them AFAIK

I guess it's only for the GCC compilers (msys2?) but is that even supported with CUDA?

No, gcc compilers don't use the flags, nor any other compiler for that matter. It's used by build systems only

Also, what about INCLUDE and friends for MSVC? Should I be setting something else?

INCLUDE is used by cl.exe and by CMake which passes it to cl.exe and nvcc. So, we should set INCLUDE only.

jaimergp commented 3 years ago

I ran nvcc --verbose demo.cu without setting INCLUDE manually and it apparently this is handled automatically? Do you think we still need it?

`nvcc --verbose demo.cu`

``` (C:\Users\Jaime\Miniconda3\conda-bld\nvcc_1607863465404\_test_env) C:\Users\Jaime\Miniconda3\conda-bld\nvcc_1607863465404\test_tmp>nvcc --verbose test.cu (C:\Users\Jaime\Miniconda3\conda-bld\nvcc_1607863465404\_test_env) C:\Users\Jaime\Miniconda3\conda-bld\nvcc_1607863465404\test_tmp>"C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.0\bin\nvcc.exe" -ccbin "cl.exe" --verbose test.cu (C:\Users\Jaime\Miniconda3\conda-bld\nvcc_1607863465404\_test_env) C:\Users\Jaime\Miniconda3\conda-bld\nvcc_1607863465404\test_tmp>call "C:/Program Files (x86)/Microsoft Visual Studio/2017/BuildTools/VC/Tools/MSVC/14.10.25017/bin/HostX64/x64/../../../../../../../VC/Auxiliary/Build/vcvars64.bat" ********************************************************************** ** Visual Studio 2017 Developer Command Prompt v15.0 ** Copyright (c) 2017 Microsoft Corporation ********************************************************************** [vcvarsall.bat] Environment initialized for: 'x64' #$ C:/Program Files (x86)/Microsoft Visual Studio/2017/BuildTools/VC/Tools/MSVC/14.10.25017/bin/HostX64/x64/../../../../../../../VC/Auxiliary/Build/vcvars64.bat #$ ALLUSERSPROFILE=C:\ProgramData #$ ANDROID_SDK_HOME=C:\Android #$ APPDATA=C:\Users\Jaime\AppData\Roaming #$ APPLICATION_INSIGHTS_NO_DIAGNOSTIC_CHANNEL=true #$ BITS=64 #$ CC=cl.exe #$ CFLAGS= -I"C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.0\include" #$ CHROME_CRASHPAD_PIPE_NAME=\\.\pipe\crashpad_13064_YWPEAYQFXBBUEHYK #$ CMAKE_GEN=Visual Studio 15 2017 Win64 #$ CMAKE_GENERATOR=Visual Studio 15 2017 Win64 #$ CommandPromptType=Native #$ CommonProgramFiles=C:\Program Files\Common Files #$ CommonProgramFiles(x86)=C:\Program Files (x86)\Common Files #$ CommonProgramW6432=C:\Program Files\Common Files #$ COMPUTERNAME=JRODRIGUEZ #$ ComSpec=C:\WINDOWS\system32\cmd.exe #$ CONDA_BAT=C:\Users\Jaime\Miniconda3\condabin\conda.bat #$ CONDA_DEFAULT_ENV=C:\Users\Jaime\Miniconda3\conda-bld\nvcc_1607863465404\_test_env #$ CONDA_EXE=C:\Users\Jaime\Miniconda3\Scripts\conda.exe #$ CONDA_PREFIX=C:\Users\Jaime\Miniconda3\conda-bld\nvcc_1607863465404\_test_env #$ CONDA_PROMPT_MODIFIER=(C:\Users\Jaime\Miniconda3\conda-bld\nvcc_1607863465404\_test_env) #$ CONDA_PYTHON_EXE=C:\Users\Jaime\Miniconda3\python.exe #$ CONDA_SHLVL=1 #$ configsetroot=C:\WINDOWS\ConfigSetRoot #$ CPPFLAGS= -I"C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.0\include" #$ CUDALIB_CONDA_NVCC_BACKUP=C:\Users\Jaime\Miniconda3\conda-bld\nvcc_1607863465404\_test_env\Library\lib\cuda.lib-conda-nvcc-backup #$ CUDA_HOME=C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.0 #$ CUDA_PATH=C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.0 #$ CUDA_PATH_CONDA_NVCC_BACKUP=C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.0 #$ CUDA_PATH_V10_1=C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v10.1 #$ CUDA_PATH_V11_0=C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.0 #$ CXX=cl.exe #$ CXXFLAGS= -I"C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.0\include" #$ DevEnvDir=C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\Common7\IDE\ #$ DISTUTILS_USE_SDK=1 #$ DriverData=C:\Windows\System32\Drivers\DriverData #$ ExtensionSdkDir=C:\Program Files (x86)\Microsoft SDKs\Windows Kits\10\ExtensionSDKs #$ FPS_BROWSER_APP_PROFILE_STRING=Internet Explorer #$ FPS_BROWSER_USER_PROFILE_STRING=Default #$ Framework40Version=v4.0 #$ FrameworkDir=C:\Windows\Microsoft.NET\Framework64\ #$ FrameworkDir64=C:\Windows\Microsoft.NET\Framework64\ #$ FrameworkVersion=v4.0.30319 #$ FrameworkVersion64=v4.0.30319 #$ g09root=C:\G09W #$ GAUSS_SCRDIR=C:\G09W\Scratch #$ HOMEDRIVE=C: #$ HOMEPATH=\Users\Jaime #$ INCLUDE=C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\VC\Tools\MSVC\14.10.25017\ATLMFC\include;C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\VC\Tools\MSVC\14.10.25017\include;C:\Program Files (x86)\Windows Kits\NETFXSDK\4.6.1\include\um;C:\Program Files (x86)\Windows Kits\10\include\10.0.10586.0\ucrt;C:\Program Files (x86)\Windows Kits\10\include\10.0.10586.0\shared;C:\Program Files (x86)\Windows Kits\10\include\10.0.10586.0\um;C:\Program Files (x86)\Windows Kits\10\include\10.0.10586.0\winrt;C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\VC\Tools\MSVC\14.10.25017\ATLMFC\include;C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\VC\Tools\MSVC\14.10.25017\include;C:\Program Files (x86)\Windows Kits\NETFXSDK\4.6.1\include\um;C:\Program Files (x86)\Windows Kits\10\include\10.0.10586.0\ucrt;C:\Program Files (x86)\Windows Kits\10\include\10.0.10586.0\shared;C:\Program Files (x86)\Windows Kits\10\include\10.0.10586.0\um;C:\Program Files (x86)\Windows Kits\10\include\10.0.10586.0\winrt; #$ LIB=C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\VC\Tools\MSVC\14.10.25017\ATLMFC\lib\x64;C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\VC\Tools\MSVC\14.10.25017\lib\x64;C:\Program Files (x86)\Windows Kits\NETFXSDK\4.6.1\lib\um\x64;C:\Program Files (x86)\Windows Kits\10\lib\10.0.10586.0\ucrt\x64;C:\Program Files (x86)\Windows Kits\10\lib\10.0.10586.0\um\x64;C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\VC\Tools\MSVC\14.10.25017\ATLMFC\lib\x64;C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\VC\Tools\MSVC\14.10.25017\lib\x64;C:\Program Files (x86)\Windows Kits\NETFXSDK\4.6.1\lib\um\x64;C:\Program Files (x86)\Windows Kits\10\lib\10.0.10586.0\ucrt\x64;C:\Program Files (x86)\Windows Kits\10\lib\10.0.10586.0\um\x64; #$ LIBCUDA_SO_CONDA_NVCC_BACKUP=C:\Users\Jaime\Miniconda3\conda-bld\nvcc_1607863465404\_test_env\Library\lib\cuda.lib-conda-nvcc-backup #$ LIBPATH=C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\VC\Tools\MSVC\14.10.25017\ATLMFC\lib\x64;C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\VC\Tools\MSVC\14.10.25017\lib\x64;C:\Program Files (x86)\Windows Kits\10\UnionMetadata;C:\Program Files (x86)\Windows Kits\10\References;C:\Windows\Microsoft.NET\Framework64\v4.0.30319;C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\VC\Tools\MSVC\14.10.25017\ATLMFC\lib\x64;C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\VC\Tools\MSVC\14.10.25017\lib\x64;C:\Program Files (x86)\Windows Kits\10\UnionMetadata;C:\Program Files (x86)\Windows Kits\10\References;C:\Windows\Microsoft.NET\Framework64\v4.0.30319; #$ LIBRARY_LIB=C:\Users\Jaime\Miniconda3\conda-bld\nvcc_1607863465404\_test_env\Library\lib #$ LOCALAPPDATA=C:\Users\Jaime\AppData\Local #$ LOGONSERVER=\\JRODRIGUEZ #$ MSSdk=1 #$ MSYS2_ARG_CONV_EXCL=/AI;/AL;/OUT;/out #$ MSYS2_ENV_CONV_EXCL=CL #$ NETFXSDKDir=C:\Program Files (x86)\Windows Kits\NETFXSDK\4.6.1\ #$ NUMBER_OF_PROCESSORS=8 #$ NVCUDASAMPLES10_1_ROOT=C:\ProgramData\NVIDIA Corporation\CUDA Samples\v10.1 #$ NVCUDASAMPLES11_0_ROOT=C:\ProgramData\NVIDIA Corporation\CUDA Samples\v11.0 #$ NVCUDASAMPLES_ROOT=C:\ProgramData\NVIDIA Corporation\CUDA Samples\v11.0 #$ NVTOOLSEXT_PATH=C:\Program Files\NVIDIA Corporation\NvToolsExt\ #$ OneDrive=C:\Users\Jaime\OneDrive #$ OneDriveConsumer=C:\Users\Jaime\OneDrive #$ ORIGINAL_XDG_CURRENT_DESKTOP=undefined #$ OS=Windows_NT #$ Path=C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64;C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\MSBuild\15.0\bin\Roslyn;C:\Program Files (x86)\Microsoft SDKs\Windows\v10.0A\bin\NETFX 4.6.1 Tools\;C:\Program Files (x86)\Windows Kits\10\bin\x64;C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\\MSBuild\15.0\bin;C:\Windows\Microsoft.NET\Framework64\v4.0.30319;C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\Common7\IDE\;C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\Common7\Tools\;C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64;C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\MSBuild\15.0\bin\Roslyn;C:\Program Files (x86)\Microsoft SDKs\Windows\v10.0A\bin\NETFX 4.6.1 Tools\;C:\Program Files (x86)\Windows Kits\10\bin\x64;C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\\MSBuild\15.0\bin;C:\Windows\Microsoft.NET\Framework64\v4.0.30319;C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\Common7\IDE\;C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\Common7\Tools\;C:\Users\Jaime\Miniconda3\conda-bld\nvcc_1607863465404\_test_env;C:\Users\Jaime\Miniconda3\conda-bld\nvcc_1607863465404\_test_env\Library\mingw-w64\bin;C:\Users\Jaime\Miniconda3\conda-bld\nvcc_1607863465404\_test_env\Library\usr\bin;C:\Users\Jaime\Miniconda3\conda-bld\nvcc_1607863465404\_test_env\Library\bin;C:\Users\Jaime\Miniconda3\conda-bld\nvcc_1607863465404\_test_env\Scripts;C:\Users\Jaime\Miniconda3\conda-bld\nvcc_1607863465404\_test_env\bin;C:\Users\Jaime\Miniconda3\condabin;C:\Users\Jaime\Miniconda3;C:\Users\Jaime\Miniconda3\Library\mingw-w64\bin;C:\Users\Jaime\Miniconda3\Library\usr\bin;C:\Users\Jaime\Miniconda3\Library\bin;C:\Users\Jaime\Miniconda3\Scripts;C:\Users\Jaime\Miniconda3\bin;C:\Users\Jaime\Miniconda3\condabin;C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.0\bin;C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.0\libnvvp;C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v10.1\bin;C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v10.1\libnvvp;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0;C:\Windows\System32\OpenSSH;C:\Program Files (x86)\NVIDIA Corporation\PhysX\Common;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0;C:\WINDOWS\System32\OpenSSH;C:\Program Files (x86)\Windows Kits\10\Windows Performance Toolkit;C:\Program Files\Intel\WiFi\bin;C:\Program Files\Common Files\Intel\WirelessCommon;C:\Android;c:\Program Files (x86)\Intel\Intel(R) Management Engine Components\DAL;c:\Program Files\Intel\Intel(R) Management Engine Components\DAL;C:\Program Files\NVIDIA Corporation\Nsight Compute 2020.1.2;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0;C:\WINDOWS\System32\OpenSSH;C:\Program Files\Docker\Docker\resources\bin;C:\ProgramData\DockerDesktop\version-bin;C:\Users\Jaime\AppData\Local\Microsoft\WindowsApps;C:\Users\Jaime\AppData\Local\Programs\Microsoft VS Code\bin;C:\Program Files (x86)\mingw-w64\i686-8.1.0-posix-dwarf-rt_v6-rev0\mingw32\bin;C:\G09W;C:\Program Files (x86)\FAHClient;C:\Program Files\7-Zip;C:\Users\Jaime\AppData\Local\atom\bin;C:\Users\Jaime\AppData\Local\Microsoft\WindowsApps;C:\Users\Jaime\Miniconda3\lib\site-packages\pywin32_system32;C:\Users\Jaime\Miniconda3\lib\site-packages\pywin32_system32 #$ PATHEXT=.COM;.EXE;.BAT;.CMD;.VBS;.VBE;.JS;.JSE;.WSF;.WSH;.MSC;.CPL #$ PKG_NAME=nvcc_win-64 #$ Platform=x64 #$ PREFIX=C:\Users\Jaime\Miniconda3\conda-bld\nvcc_1607863465404\_test_env #$ PROCESSOR_ARCHITECTURE=AMD64 #$ PROCESSOR_IDENTIFIER=Intel64 Family 6 Model 142 Stepping 10, GenuineIntel #$ PROCESSOR_LEVEL=6 #$ PROCESSOR_REVISION=8e0a #$ ProgramData=C:\ProgramData #$ ProgramFiles=C:\Program Files #$ ProgramFiles(x86)=C:\Program Files (x86) #$ ProgramW6432=C:\Program Files #$ PROMPT=(C:\Users\Jaime\Miniconda3\conda-bld\nvcc_1607863465404\_test_env) $P$G #$ PSExecutionPolicyPreference=Bypass #$ PSModulePath=C:\Users\Jaime\Documents\WindowsPowerShell\Modules;C:\Program Files\WindowsPowerShell\Modules;C:\WINDOWS\system32\WindowsPowerShell\v1.0\Modules #$ PUBLIC=C:\Users\Public #$ PY_VCRUNTIME_REDIST=\bin\vcruntime140.dll #$ SystemDrive=C: #$ SystemRoot=C:\WINDOWS #$ UCRTVersion=10.0.10586.0 #$ UniversalCRTSdkDir=C:\Program Files (x86)\Windows Kits\10\ #$ USERDOMAIN=JRODRIGUEZ #$ USERDOMAIN_ROAMINGPROFILE=JRODRIGUEZ #$ USERNAME=Jaime #$ USERPROFILE=C:\Users\Jaime #$ VBOX_MSI_INSTALL_PATH=C:\Program Files\Oracle\VirtualBox\ #$ VCIDEInstallDir=C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\Common7\IDE\VC\ #$ VCINSTALLDIR=C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\VC\ #$ VCToolsInstallDir=C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\VC\Tools\MSVC\14.10.25017\ #$ VCToolsRedistDir=C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\VC\Redist\MSVC\14.10.25017\ #$ VisualStudioVersion=15.0 #$ VS150COMNTOOLS=C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\Common7\Tools\ #$ VSCMD_ARG_app_plat=Desktop #$ VSCMD_ARG_HOST_ARCH=x64 #$ VSCMD_ARG_TGT_ARCH=x64 #$ VSCMD_VER=15.0 #$ VSINSTALLDIR=C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\ #$ VS_MAJOR=15 #$ VS_VERSION=15.0 #$ VS_YEAR=2017 #$ windir=C:\WINDOWS #$ WindowsLibPath=C:\Program Files (x86)\Windows Kits\10\UnionMetadata;C:\Program Files (x86)\Windows Kits\10\References #$ WindowsSdkBinPath=C:\Program Files (x86)\Windows Kits\10\bin\ #$ WindowsSdkDir=C:\Program Files (x86)\Windows Kits\10\ #$ WindowsSDKLibVersion=10.0.10586.0\ #$ WindowsSDKVer=10.0.10586.0 #$ WindowsSDKVersion=10.0.10586.0\ #$ WindowsSDK_ExecutablePath_x64=C:\Program Files (x86)\Microsoft SDKs\Windows\v10.0A\bin\NETFX 4.6.1 Tools\x64\ #$ WindowsSDK_ExecutablePath_x86=C:\Program Files (x86)\Microsoft SDKs\Windows\v10.0A\bin\NETFX 4.6.1 Tools\ #$ WSLENV=VSCODE_CLI_REMOTE_ENV/w:ELECTRON_RUN_AS_NODE/w:VSCODE_WSL_EXT_LOCATION/up #$ WT_PROFILE_ID={c6eaf9f4-32a7-5fdc-b5cf-066e8a4b1e40} #$ WT_SESSION=8ea8eedb-3a11-4be1-aaa3-3dd8455675e8 #$ ZES_ENABLE_SYSMAN=1 #$ TERM_PROGRAM=vscode #$ TERM_PROGRAM_VERSION=1.52.0 #$ LANG=en_GB.UTF-8 #$ COLORTERM=truecolor #$ _CONDA_EXE=C:\Users\Jaime\Miniconda3\Scripts\conda.exe #$ _CONDA_ROOT=C:\Users\Jaime\Miniconda3 #$ __DOTNET_ADD_64BIT=1 #$ __DOTNET_PREFERRED_BITNESS=64 #$ __VSCMD_PREINIT_PATH=C:\Users\Jaime\Miniconda3\conda-bld\nvcc_1607863465404\_test_env;C:\Users\Jaime\Miniconda3\conda-bld\nvcc_1607863465404\_test_env\Library\mingw-w64\bin;C:\Users\Jaime\Miniconda3\conda-bld\nvcc_1607863465404\_test_env\Library\usr\bin;C:\Users\Jaime\Miniconda3\conda-bld\nvcc_1607863465404\_test_env\Library\bin;C:\Users\Jaime\Miniconda3\conda-bld\nvcc_1607863465404\_test_env\Scripts;C:\Users\Jaime\Miniconda3\conda-bld\nvcc_1607863465404\_test_env\bin;C:\Users\Jaime\Miniconda3\condabin;C:\Users\Jaime\Miniconda3;C:\Users\Jaime\Miniconda3\Library\mingw-w64\bin;C:\Users\Jaime\Miniconda3\Library\usr\bin;C:\Users\Jaime\Miniconda3\Library\bin;C:\Users\Jaime\Miniconda3\Scripts;C:\Users\Jaime\Miniconda3\bin;C:\Users\Jaime\Miniconda3\condabin;C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.0\bin;C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.0\libnvvp;C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v10.1\bin;C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v10.1\libnvvp;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0;C:\Windows\System32\OpenSSH;C:\Program Files (x86)\NVIDIA Corporation\PhysX\Common;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0;C:\WINDOWS\System32\OpenSSH;C:\Program Files (x86)\Windows Kits\10\Windows Performance Toolkit;C:\Program Files\Intel\WiFi\bin;C:\Program Files\Common Files\Intel\WirelessCommon;C:\Android;c:\Program Files (x86)\Intel\Intel(R) Management Engine Components\DAL;c:\Program Files\Intel\Intel(R) Management Engine Components\DAL;C:\Program Files\NVIDIA Corporation\Nsight Compute 2020.1.2;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0;C:\WINDOWS\System32\OpenSSH;C:\Program Files\Docker\Docker\resources\bin;C:\ProgramData\DockerDesktop\version-bin;C:\Users\Jaime\AppData\Local\Microsoft\WindowsApps;C:\Users\Jaime\AppData\Local\Programs\Microsoft VS Code\bin;C:\Program Files (x86)\mingw-w64\i686-8.1.0-posix-dwarf-rt_v6-rev0\mingw32\bin;C:\G09W;C:\Program Files (x86)\FAHClient;C:\Program Files\7-Zip;C:\Users\Jaime\AppData\Local\atom\bin;C:\Users\Jaime\AppData\Local\Microsoft\WindowsApps;C:\Users\Jaime\Miniconda3\lib\site-packages\pywin32_system32;C:\Users\Jaime\Miniconda3\lib\site-packages\pywin32_system32 #$ __VSCMD_PREINIT_VS150COMNTOOLS=C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\Common7\Tools\ #$ PATH=C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64;C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64;C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\MSBuild\15.0\bin\Roslyn;C:\Program Files (x86)\Microsoft SDKs\Windows\v10.0A\bin\NETFX 4.6.1 Tools\;C:\Program Files (x86)\Windows Kits\10\bin\x64;C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\\MSBuild\15.0\bin;C:\Windows\Microsoft.NET\Framework64\v4.0.30319;C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\Common7\IDE\;C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\Common7\Tools\;C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64;C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\MSBuild\15.0\bin\Roslyn;C:\Program Files (x86)\Microsoft SDKs\Windows\v10.0A\bin\NETFX 4.6.1 Tools\;C:\Program Files (x86)\Windows Kits\10\bin\x64;C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\\MSBuild\15.0\bin;C:\Windows\Microsoft.NET\Framework64\v4.0.30319;C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\Common7\IDE\;C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\Common7\Tools\;C:\Users\Jaime\Miniconda3\conda-bld\nvcc_1607863465404\_test_env;C:\Users\Jaime\Miniconda3\conda-bld\nvcc_1607863465404\_test_env\Library\mingw-w64\bin;C:\Users\Jaime\Miniconda3\conda-bld\nvcc_1607863465404\_test_env\Library\usr\bin;C:\Users\Jaime\Miniconda3\conda-bld\nvcc_1607863465404\_test_env\Library\bin;C:\Users\Jaime\Miniconda3\conda-bld\nvcc_1607863465404\_test_env\Scripts;C:\Users\Jaime\Miniconda3\conda-bld\nvcc_1607863465404\_test_env\bin;C:\Users\Jaime\Miniconda3\condabin;C:\Users\Jaime\Miniconda3;C:\Users\Jaime\Miniconda3\Library\mingw-w64\bin;C:\Users\Jaime\Miniconda3\Library\usr\bin;C:\Users\Jaime\Miniconda3\Library\bin;C:\Users\Jaime\Miniconda3\Scripts;C:\Users\Jaime\Miniconda3\bin;C:\Users\Jaime\Miniconda3\condabin;C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.0\bin;C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.0\libnvvp;C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v10.1\bin;C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v10.1\libnvvp;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0;C:\Windows\System32\OpenSSH;C:\Program Files (x86)\NVIDIA Corporation\PhysX\Common;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0;C:\WINDOWS\System32\OpenSSH;C:\Program Files (x86)\Windows Kits\10\Windows Performance Toolkit;C:\Program Files\Intel\WiFi\bin;C:\Program Files\Common Files\Intel\WirelessCommon;C:\Android;c:\Program Files (x86)\Intel\Intel(R) Management Engine Components\DAL;c:\Program Files\Intel\Intel(R) Management Engine Components\DAL;C:\Program Files\NVIDIA Corporation\Nsight Compute 2020.1.2;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0;C:\WINDOWS\System32\OpenSSH;C:\Program Files\Docker\Docker\resources\bin;C:\ProgramData\DockerDesktop\version-bin;C:\Users\Jaime\AppData\Local\Microsoft\WindowsApps;C:\Users\Jaime\AppData\Local\Programs\Microsoft VS Code\bin;C:\Program Files (x86)\mingw-w64\i686-8.1.0-posix-dwarf-rt_v6-rev0\mingw32\bin;C:\G09W;C:\Program Files (x86)\FAHClient;C:\Program Files\7-Zip;C:\Users\Jaime\AppData\Local\atom\bin;C:\Users\Jaime\AppData\Local\Microsoft\WindowsApps;C:\Users\Jaime\Miniconda3\lib\site-packages\pywin32_system32;C:\Users\Jaime\Miniconda3\lib\site-packages\pywin32_system32 #$ _NVVM_BRANCH_=nvvm #$ _SPACE_= #$ _CUDART_=cudart #$ _HERE_=C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.0\bin #$ _THERE_=C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.0\bin #$ _TARGET_SIZE_= #$ _TARGET_DIR_= #$ _TARGET_SIZE_=64 #$ _WIN_PLATFORM_=x64 #$ TOP=C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.0\bin/.. #$ NVVMIR_LIBRARY_DIR=C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.0\bin/../nvvm/libdevice #$ PATH=C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.0\bin/../nvvm/bin;C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.0\bin;C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.0\bin/../lib;C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64;C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64;C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\MSBuild\15.0\bin\Roslyn;C:\Program Files (x86)\Microsoft SDKs\Windows\v10.0A\bin\NETFX 4.6.1 Tools\;C:\Program Files (x86)\Windows Kits\10\bin\x64;C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\\MSBuild\15.0\bin;C:\Windows\Microsoft.NET\Framework64\v4.0.30319;C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\Common7\IDE\;C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\Common7\Tools\;C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64;C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\MSBuild\15.0\bin\Roslyn;C:\Program Files (x86)\Microsoft SDKs\Windows\v10.0A\bin\NETFX 4.6.1 Tools\;C:\Program Files (x86)\Windows Kits\10\bin\x64;C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\\MSBuild\15.0\bin;C:\Windows\Microsoft.NET\Framework64\v4.0.30319;C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\Common7\IDE\;C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\Common7\Tools\;C:\Users\Jaime\Miniconda3\conda-bld\nvcc_1607863465404\_test_env;C:\Users\Jaime\Miniconda3\conda-bld\nvcc_1607863465404\_test_env\Library\mingw-w64\bin;C:\Users\Jaime\Miniconda3\conda-bld\nvcc_1607863465404\_test_env\Library\usr\bin;C:\Users\Jaime\Miniconda3\conda-bld\nvcc_1607863465404\_test_env\Library\bin;C:\Users\Jaime\Miniconda3\conda-bld\nvcc_1607863465404\_test_env\Scripts;C:\Users\Jaime\Miniconda3\conda-bld\nvcc_1607863465404\_test_env\bin;C:\Users\Jaime\Miniconda3\condabin;C:\Users\Jaime\Miniconda3;C:\Users\Jaime\Miniconda3\Library\mingw-w64\bin;C:\Users\Jaime\Miniconda3\Library\usr\bin;C:\Users\Jaime\Miniconda3\Library\bin;C:\Users\Jaime\Miniconda3\Scripts;C:\Users\Jaime\Miniconda3\bin;C:\Users\Jaime\Miniconda3\condabin;C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.0\bin;C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.0\libnvvp;C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v10.1\bin;C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v10.1\libnvvp;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0;C:\Windows\System32\OpenSSH;C:\Program Files (x86)\NVIDIA Corporation\PhysX\Common;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0;C:\WINDOWS\System32\OpenSSH;C:\Program Files (x86)\Windows Kits\10\Windows Performance Toolkit;C:\Program Files\Intel\WiFi\bin;C:\Program Files\Common Files\Intel\WirelessCommon;C:\Android;c:\Program Files (x86)\Intel\Intel(R) Management Engine Components\DAL;c:\Program Files\Intel\Intel(R) Management Engine Components\DAL;C:\Program Files\NVIDIA Corporation\Nsight Compute 2020.1.2;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0;C:\WINDOWS\System32\OpenSSH;C:\Program Files\Docker\Docker\resources\bin;C:\ProgramData\DockerDesktop\version-bin;C:\Users\Jaime\AppData\Local\Microsoft\WindowsApps;C:\Users\Jaime\AppData\Local\Programs\Microsoft VS Code\bin;C:\Program Files (x86)\mingw-w64\i686-8.1.0-posix-dwarf-rt_v6-rev0\mingw32\bin;C:\G09W;C:\Program Files (x86)\FAHClient;C:\Program Files\7-Zip;C:\Users\Jaime\AppData\Local\atom\bin;C:\Users\Jaime\AppData\Local\Microsoft\WindowsApps;C:\Users\Jaime\Miniconda3\lib\site-packages\pywin32_system32;C:\Users\Jaime\Miniconda3\lib\site-packages\pywin32_system32 #$ INCLUDES="-IC:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.0\bin/../include" #$ LIBRARIES= "/LIBPATH:C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.0\bin/../lib/x64" #$ CUDAFE_FLAGS= #$ PTXAS_FLAGS= #$ erase C:/Users/Jaime/AppData/Local/Temp/tmpxft_000032c8_00000000-11_a_dlink.reg.c test.cu #$ cl.exe @"C:\Users\Jaime\AppData\Local\Temp/tmpxft_000032c8_00000000-14.res" > "C:/Users/Jaime/AppData/Local/Temp/tmpxft_000032c8_00000000-13_test.cpp1.ii" #$ erase C:\Users\Jaime\AppData\Local\Temp/tmpxft_000032c8_00000000-14.res #$ cicc --microsoft_version=1910 --msvc_target_version=1910 --compiler_bindir "C:/Program Files (x86)/Microsoft Visual Studio/2017/BuildTools/VC/Tools/MSVC/14.10.25017/bin/HostX64/x64/../../../../../../.." --sdk_dir "C:/Program Files (x86)/Windows Kits/10/" --orig_src_file_name "test.cu" --allow_managed -arch compute_52 -m64 -ftz=0 -prec_div=1 -prec_sqrt=1 -fmad=1 --include_file_name "tmpxft_000032c8_00000000-7_test.fatbin.c" -tused -nvvmir-library "C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.0\bin/../nvvm/libdevice/libdevice.10.bc" --gen_module_id_file --module_id_file_name "C:/Users/Jaime/AppData/Local/Temp/tmpxft_000032c8_00000000-8_test.module_id" --gen_c_file_name "C:/Users/Jaime/AppData/Local/Temp/tmpxft_000032c8_00000000-10_test.cudafe1.c" --stub_file_name "C:/Users/Jaime/AppData/Local/Temp/tmpxft_000032c8_00000000-10_test.cudafe1.stub.c" --gen_device_file_name "C:/Users/Jaime/AppData/Local/Temp/tmpxft_000032c8_00000000-10_test.cudafe1.gpu" "C:/Users/Jaime/AppData/Local/Temp/tmpxft_000032c8_00000000-13_test.cpp1.ii" -o "C:/Users/Jaime/AppData/Local/Temp/tmpxft_000032c8_00000000-10_test.ptx" #$ ptxas -arch=sm_52 -m64 "C:/Users/Jaime/AppData/Local/Temp/tmpxft_000032c8_00000000-10_test.ptx" -o "C:/Users/Jaime/AppData/Local/Temp/tmpxft_000032c8_00000000-15_test.sm_52.cubin" #$ fatbinary -64 --cicc-cmdline="-ftz=0 -prec_div=1 -prec_sqrt=1 -fmad=1 " "--image3=kind=elf,sm=52,file=C:/Users/Jaime/AppData/Local/Temp/tmpxft_000032c8_00000000-15_test.sm_52.cubin" "--image3=kind=ptx,sm=52,file=C:/Users/Jaime/AppData/Local/Temp/tmpxft_000032c8_00000000-10_test.ptx" --embedded-fatbin="C:/Users/Jaime/AppData/Local/Temp/tmpxft_000032c8_00000000-7_test.fatbin.c" #$ erase C:/Users/Jaime/AppData/Local/Temp/tmpxft_000032c8_00000000-7_test.fatbin #$ cl.exe @"C:\Users\Jaime\AppData\Local\Temp/tmpxft_000032c8_00000000-16.res" > "C:/Users/Jaime/AppData/Local/Temp/tmpxft_000032c8_00000000-9_test.cpp4.ii" #$ erase C:\Users\Jaime\AppData\Local\Temp/tmpxft_000032c8_00000000-16.res #$ cudafe++ --microsoft_version=1910 --msvc_target_version=1910 --compiler_bindir "C:/Program Files (x86)/Microsoft Visual Studio/2017/BuildTools/VC/Tools/MSVC/14.10.25017/bin/HostX64/x64/../../../../../../.." --sdk_dir "C:/Program Files (x86)/Windows Kits/10/" --orig_src_file_name "test.cu" --allow_managed --m64 --parse_templates --gen_c_file_name "C:/Users/Jaime/AppData/Local/Temp/tmpxft_000032c8_00000000-10_test.cudafe1.cpp" --stub_file_name "tmpxft_000032c8_00000000-10_test.cudafe1.stub.c" --module_id_file_name "C:/Users/Jaime/AppData/Local/Temp/tmpxft_000032c8_00000000-8_test.module_id" "C:/Users/Jaime/AppData/Local/Temp/tmpxft_000032c8_00000000-9_test.cpp4.ii" #$ cl.exe @"C:\Users\Jaime\AppData\Local\Temp/tmpxft_000032c8_00000000-18.res" -Fo"C:/Users/Jaime/AppData/Local/Temp/tmpxft_000032c8_00000000-17_test.obj" tmpxft_000032c8_00000000-10_test.cudafe1.cpp #$ erase C:\Users\Jaime\AppData\Local\Temp/tmpxft_000032c8_00000000-18.res #$ nvlink -optf "C:\Users\Jaime\AppData\Local\Temp/tmpxft_000032c8_00000000-20.optf" #$ fatbinary -64 --cicc-cmdline="-ftz=0 -prec_div=1 -prec_sqrt=1 -fmad=1 " -link "--image3=kind=elf,sm=52,file=C:/Users/Jaime/AppData/Local/Temp/tmpxft_000032c8_00000000-19_a_dlink.sm_52.cubin" --embedded-fatbin="C:/Users/Jaime/AppData/Local/Temp/tmpxft_000032c8_00000000-12_a_dlink.fatbin.c" #$ erase C:/Users/Jaime/AppData/Local/Temp/tmpxft_000032c8_00000000-12_a_dlink.fatbin #$ cl.exe @"C:\Users\Jaime\AppData\Local\Temp/tmpxft_000032c8_00000000-22.res" -Fo"C:/Users/Jaime/AppData/Local/Temp/tmpxft_000032c8_00000000-21_a_dlink.obj" link.stub #$ erase C:\Users\Jaime\AppData\Local\Temp/tmpxft_000032c8_00000000-22.res #$ cl.exe @"C:\Users\Jaime\AppData\Local\Temp/tmpxft_000032c8_00000000-23.res" -Fe"a.exe" Creating library a.lib and object a.exp #$ erase C:\Users\Jaime\AppData\Local\Temp/tmpxft_000032c8_00000000-23.res ```

h-vetinari commented 3 years ago

Could we have one build with the flags-path fixes before figuring out whether CFLAGS & INCLUDE is absolutely necessary? 🙃

jaimergp commented 3 years ago

I am ok with merging this one and dealing (or not) with INCLUDE later. We need one more maintainer to agree though :)

jaimergp commented 3 years ago

I guess that means we are merging! I'll leave it here for one more hour just in case somebody wants to say otherwise.

jaimergp commented 3 years ago

There we go!

jakirkham commented 3 years ago

Thanks Jaime for the PR and everyone for the reviews! 😄

conda-forge / nvcc-feedstock

[Windows] Export CFLAGS and friends with quoted paths #57