search

conda-forge / nvcc-feedstock

A conda-smithy repository for nvcc.
BSD 3-Clause "New" or "Revised" License
12 stars 23 forks source link

expand matrix to cover 9.2-11.2 #64

Closed jaimergp closed 3 years ago

jaimergp commented 3 years ago

MNT: Re-rendered with conda-build 3.20.5, conda-smithy 3.8.6, and conda-forge-pinning 2021.02.16.21.37.58

Checklist

One of the premises for shrinking the CUDA matrix as part of https://github.com/conda-forge/conda-forge-pinning-feedstock/pull/1162 was that the maintainer could opt-in for more versions using conda_build_config.yaml. I have added what I think should be the full file (and that we will eventually link in the docs), but since conda-smithy applies the migrators after conda_build_config it has no effect: the migrator shadows the changes.

Is this something we need to address in conda-smithy?

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

isuruf commented 3 years ago

You can just delete the other migrators.

jaimergp commented 3 years ago

That implies that users that need to opt-in would switch to a all-manual mode they need to take care of, right?

jaimergp commented 3 years ago

Replacing the 11.1/11.2 migrator with the current conda_build_config (which contains more comments than usual) seems to work.

isuruf commented 3 years ago

That implies that users that need to opt-in would switch to a all-manual mode they need to take care of, right?

Yes. I wouldn't worry about it being all-manual until a maintainer comes forward who says they need the older versions.

jakirkham commented 3 years ago

Thanks Jaime! 😄