search

conda-forge / nvcc-feedstock

A conda-smithy repository for nvcc.
BSD 3-Clause "New" or "Revised" License
12 stars 23 forks source link

Arch Migrator #67

Closed regro-cf-autotick-bot closed 3 years ago

regro-cf-autotick-bot commented 3 years ago

This feedstock is being rebuilt as part of the aarch64/ppc64le migration.

Feel free to merge the PR if CI is all green, but please don't close it without reaching out the the ARM migrators first at @conda-forge/arm-arch.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable. Finally, feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/840165127, please use this URL for debugging

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

jakirkham commented 3 years ago

Yeah that's right. This isn't actually ready to merge despite the green checkmark.

jakirkham commented 3 years ago

For context Keith, I think we are missing cudatoolkit ( https://github.com/conda-forge/cudatoolkit-feedstock/pull/56 ) and Docker images currently. The latter might not be strictly needed to merge this though. The former is needed as we have it in run_exports:

https://github.com/conda-forge/nvcc-feedstock/blob/25f322292e8ac423b25af323199caeb2f307460c/recipe/meta.yaml#L32-L34

Think that is it, but correct me if you see something else missing Leo

leofang commented 3 years ago

Thanks John for filling in the context! Yes I think it's right. The order of getting nvcc or the docker image done first does not matter, as long as they're done before we fire up a global migrator IIUC.

regro-cf-autotick-bot commented 3 years ago

I see that this PR has conflicts, and I'm the only committer. I'm going to close this PR and will make another one as appropriate. This was generated by https://github.com/regro/autotick-bot/actions/runs/1286090543

jakirkham commented 3 years ago

ppc64le was addressed in PR ( https://github.com/conda-forge/nvcc-feedstock/pull/66 ) and aarch64 in PR ( https://github.com/conda-forge/nvcc-feedstock/pull/70 )