Add freeimage - Githubissues

conda-forge / occt-feedstock

A conda-smithy repository for occt.

BSD 3-Clause "New" or "Revised" License

4 stars 21 forks source link

Closed frmdstryr closed 4 years ago

frmdstryr commented 4 years ago

Checklist

[x] Used a fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

For #40

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

looooo commented 4 years ago

@frmdstryr please add:

      -D USE_FREEIMAGE:BOOL=ON

to build.sh and bld.bat. I am not sure freeimage is already used by simple adding it to the host-env.

frmdstryr commented 4 years ago

Thanks, added! It looks like it's used now: