search

conda-forge / occt-feedstock

A conda-smithy repository for occt.
BSD 3-Clause "New" or "Revised" License
4 stars 21 forks source link

Rebuild for vtk901 #44

Closed regro-cf-autotick-bot closed 4 years ago

regro-cf-autotick-bot commented 4 years ago

This PR has been triggered in an effort to update vtk901.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

This package has the following downstream children:

And potentially more.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable. Finally, feel free to drop us a line if there are any issues! This PR was generated by https://circleci.com/gh/regro/circle_worker/27926, please use this URL for debugging

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

Documentation on acceptable licenses can be found here.

looooo commented 4 years ago

@adam-urbanczyk maybe you have some time to look into this.

adam-urbanczyk commented 4 years ago

I'll take a look. Not sure though if OCCT 7.4 is compatible with VTK9...

looooo commented 4 years ago

ok, maybe not yet time to update to vtk9.

adam-urbanczyk commented 4 years ago

OK, I tried to build locally, and I get stuck on this:

-- Could NOT find OpenGL (missing: OPENGL_opengl_LIBRARY OPENGL_glx_LIBRARY OpenGL) 
CMake Error at CMake/vtkModule.cmake:4145 (message):
looooo commented 4 years ago

did you use docker?

looooo commented 4 years ago

@adam-urbanczyk is vtk-support important for you? It seems to add quite some troubles on packages depending on occt. For me it would be easier if we could simple skip the vtk-support. Otherwise I think we should look into splitting occt in occt and occt-vtk.

ref: https://github.com/conda-forge/netgen-feedstock/pull/35

adam-urbanczyk commented 4 years ago

Yes, I'm trying to integrate VTK based visualization into OCP. I checked the error, are you sure that it is fundamentally related to VTK? Netgen does not depend on it and it seems to build fine on all OSes. It might be good to pin the VTK requirement to the version used for building.

looooo commented 4 years ago

yes it's likely vtk is not the issue here. anyway vtk brings in a lot of deps so splitting occt in a vtk-dependent package and a vtk-independent package definitely makes sense.

edit: phone transformed into total nonsense ...

adam-urbanczyk commented 4 years ago

OK, if you insist on splitting are you open to handling this via conda_build_config.yaml and building here?

looooo commented 4 years ago

I don't want to split the recipe. There is a way to create several outputs (packages) from one recipe: https://docs.conda.io/projects/conda-build/en/latest/resources/define-metadata.html#id11 But I never did this before so not yet sure how to do it.

Anyway, the goal is to have a occt-vtk package depending on occt and vtk and a occt-package which is independent of vtk. So OCP has to depend on occt-vtk (Not sure if this also works with conda-forge-pinning stuff (rerendering, pinning). So it might be necessary to depend on both (occt, occt-vtk)).

This is getting complicated pretty fast. Would be nice to have some guidance from @conda-forge/core to get things done right.

adam-urbanczyk commented 4 years ago

That sounds even better! I never did this myself, but I'll look into it.

wolfv commented 4 years ago

hey there happy to help you guys, I have split quite a few recipes recently. let me know if there are questions

looooo commented 4 years ago

done in https://github.com/conda-forge/occt-feedstock/pull/46