conda-forge / omniorb-feedstock

A conda-smithy repository for omniorb.
BSD 3-Clause "New" or "Revised" License
0 stars 9 forks source link

Specify minimum cmake version #23

Closed kinsamanka closed 2 years ago

kinsamanka commented 2 years ago

Local conda-build using this recipe fails due to wrong cmake version installed.

See: https://github.com/conda-forge/omniorb-feedstock/blob/e6fdaac934c356bf390ed9025bf9c8ad3f759e7d/recipe/omniorb-4.2.4-cmake.patch#L38

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

beenje commented 2 years ago

Thanks for the change!

I don't think we want to build new packages for that fix (and that would require to bump the build number).

Could you please just update your last commit and put [ci skip] ***NO_CI*** in the commit message (you could rebase and squash both commits if you know how to do it). See https://conda-forge.org/docs/maintainer/infrastructure.html#skipping-ci-builds

beenje commented 2 years ago

Sorry I had forgotten about this PR. Thanks for the change!