Add windows support - Githubissues

conda-forge / omniorb-feedstock

A conda-smithy repository for omniorb.

BSD 3-Clause "New" or "Revised" License

0 stars 9 forks source link

Closed beenje closed 3 years ago

beenje commented 3 years ago

Checklist

[X] Used a personal fork of the feedstock to propose changes
[X] Bumped the build number (if the version is unchanged)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[X] Ensured the license file is being packaged.

I found this fork that added CMake to build omniORB: https://github.com/CaeruleusAqua/omniORB-cmake This makes it much easier to build on Windows. I made a few changes and generated a patch from this repo: https://github.com/beenje/omniORB-cmake

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [12, 21]

For recipe:

License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

beenje commented 3 years ago

@conda-forge-admin, please rerender

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

carlodri commented 3 years ago

Looks great thanks!!

beenje commented 3 years ago

That was fast. Thanks!