conda-forge / onnxruntime-feedstock

A conda-smithy repository for onnxruntime.
BSD 3-Clause "New" or "Revised" License
1 stars 20 forks source link

Add run_exports for onnxruntime-cpp without modifying SOVERSION #102

Closed traversaro closed 9 months ago

traversaro commented 9 months ago

Variant of https://github.com/conda-forge/onnxruntime-feedstock/pull/78 (thanks @kuepe-sl) to add run_exports to onnxruntime-cpp, without modifying SOVERSION.

This does not halts the discussion ongoing in https://github.com/conda-forge/onnxruntime-feedstock/pull/78, but solves the specific problem of adding run_exports to onnxruntime-cpp . If a consensus is reached to relax run_exports condition in the future, we can always do that in the future. However, there is no need to make the better (relaxed run_exports) enemy of the good (fixing the missing run_exports).

fyi @conda-forge/onnxruntime

Checklist

conda-forge-webservices[bot] commented 9 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

traversaro commented 9 months ago

@conda-forge-admin, please rerender

github-actions[bot] commented 9 months ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

Thus the PR was passing and merged! Have a great day!