Bump build number - Githubissues

cbourjau commented 6 months ago

On conda-forge onnxruntime-novec and onnxruntime-novec-cpp are still on version 1.17.1 while the non-novec variants are on 1.17.3 (there was no proper 1.17.2 release). This is an attempt to get the latest versions for the novec variants into conda-forge, too.

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-webservices[bot] commented 6 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

This recipe is using a compiler, which now requires adding a build dependence on {{ stdlib("c") }} as well. For further details, please see https://github.com/conda-forge/conda-forge.github.io/issues/2102.

conda-forge-webservices[bot] commented 6 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

hmaarrfk commented 6 months ago

@conda-forge-admin please rerender

traversaro commented 6 months ago

Windows failure is:

%SRC_DIR%>IF "1" == "1" (
IF "" == "" SET "CMAKE_GENERATOR_PLATFORM=x64"  
 IF "" == "" SET "CMAKE_GENERATOR_TOOLSET=v143" 
) 
CMake Deprecation Warning at CMakeLists.txt:14 (cmake_policy):
  The OLD behavior for policy CMP0104 will be removed from a future version
  of CMake.

  The cmake-policies(7) manual explains that the OLD behaviors of all
  policies are deprecated and that a policy should be set to OLD only under
  specific short-term circumstances.  Projects should be ported to the NEW
  behavior and not rely on setting a policy to OLD.

CMake Error at D:/bld/onnxruntime_1715856292753/_build_env/Library/share/cmake-3.29/Modules/CMakeDetermineCCompiler.cmake:49 (message):
  Could not find compiler set in environment variable CC:

  cl.exe.
Call Stack (most recent call first):
  CMakeLists.txt:20 (project)

CMake Error: CMAKE_C_COMPILER not set, after EnableLanguage
CMake Error: CMAKE_CXX_COMPILER not set, after EnableLanguage
CMake Error: CMAKE_ASM_COMPILER not set, after EnableLanguage
-- Configuring incomplete, errors occurred!
Traceback (most recent call last):

I have the same error in https://github.com/conda-forge/onnxruntime-feedstock/pull/115, so I guess it does depend on the PR. Probably the VS version in the azure image got updated and vc-feedstock needs to be updated?

xhochy commented 6 months ago

This is the actual error:

C:\Program Files\Microsoft Visual Studio\2022\Enterprise>CALL "VC\Auxiliary\Build\vcvars64.bat" -vcvars_ver=14.38 10.0.22621.0 
**********************************************************************
** Visual Studio 2022 Developer Command Prompt v17.9.7
** Copyright (c) 2022 Microsoft Corporation
**********************************************************************
[ERROR:vcvars.bat] Toolset directory for version '14.38' was not found.

cbourjau commented 6 months ago

The OSX builds fail with the following error:

FAILED: CMakeFiles/onnxruntime_common.dir$SRC_DIR/onnxruntime/core/common/logging/sinks/ostream_sink.cc.o 
$BUILD_PREFIX/bin/arm64-apple-darwin20.0.0-clang++ -DCPUINFO_SUPPORTED_PLATFORM=1 -DEIGEN_MPL2_ONLY -DEIGEN_USE_THREADS -DNSYNC_ATOMIC_CPP11 -DONLY_C_LOCALE=0 -DORT_ENABLE_STREAM -DPLATFORM_POSIX -I$SRC_DIR/build-ci/Release/_deps/utf8_range-src -I$SRC_DIR/include/onnxruntime -I$SRC_DIR/include/onnxruntime/core/session -I$SRC_DIR/build-ci/Release/_deps/pytorch_cpuinfo-src/include -I$SRC_DIR/build-ci/Release/_deps/google_nsync-src/public -I$SRC_DIR/build-ci/Release -I$SRC_DIR/onnxruntime -I$SRC_DIR/build-ci/Release/_deps/abseil_cpp-src -I$SRC_DIR/build-ci/Release/_deps/eigen-src -I$SRC_DIR/build-ci/Release/_deps/safeint-src -isystem $SRC_DIR/build-ci/Release/_deps/gsl-src/include -ftree-vectorize -fPIC -fstack-protector-strong -O2 -pipe -stdlib=libc++ -fvisibility-inlines-hidden -fmessage-length=0 -isystem $PREFIX/include -fdebug-prefix-map=$SRC_DIR=/usr/local/src/conda/onnxruntime-1.17.3 -fdebug-prefix-map=$PREFIX=/usr/local/src/conda-prefix -ffunction-sections -fdata-sections -fvisibility=hidden -fvisibility-inlines-hidden -DCPUINFO_SUPPORTED -O3 -DNDEBUG -std=gnu++20 -arch arm64 -isysroot /Applications/Xcode_14.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.0.sdk -mmacosx-version-min=11.0 -fPIC -Wall -Wextra -Wno-unused-parameter -Wno-deprecated-copy -Wno-tautological-pointer-compare -Wno-ambiguous-reversed-operator -Wno-deprecated-anon-enum-enum-conversion -Wno-undefined-var-template -Wno-deprecated-builtins -Wshorten-64-to-32 -MD -MT CMakeFiles/onnxruntime_common.dir$SRC_DIR/onnxruntime/core/common/logging/sinks/ostream_sink.cc.o -MF CMakeFiles/onnxruntime_common.dir$SRC_DIR/onnxruntime/core/common/logging/sinks/ostream_sink.cc.o.d -o CMakeFiles/onnxruntime_common.dir$SRC_DIR/onnxruntime/core/common/logging/sinks/ostream_sink.cc.o -c $SRC_DIR/onnxruntime/core/common/logging/sinks/ostream_sink.cc
$SRC_DIR/onnxruntime/core/common/logging/sinks/ostream_sink.cc:48:7: error: use of overloaded operator '<<' is ambiguous (with operand types 'std::ostringstream' (aka 'basic_ostringstream<char>') and 'const Timestamp' (aka 'const time_point<std::chrono::system_clock>'))
  msg << timestamp << " [" << message.SeverityPrefix() << ":" << message.Category() << ":" << logger_id << ", "
  ~~~ ^  ~~~~~~~~~

I noticed that libcxx version 17.0.6 is being used here, while the remaining clang toolchain is at 16.0.6. Setting libcxx !=17.0.6 in the build dependencies makes the build pass locally, but this doesn't seem like a viable solution. Any ideas on how to resolve this part?

hmaarrfk commented 6 months ago

@conda-forge-admin please rerender

hmaarrfk commented 6 months ago

@conda-forge-admin please rerender

github-actions[bot] commented 6 months ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/onnxruntime-feedstock/actions/runs/9140064345.

github-actions[bot] commented 6 months ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/onnxruntime-feedstock/actions/runs/9140085961.

hmaarrfk commented 6 months ago

for OSX: Try to pull in this patch: https://github.com/microsoft/onnxruntime/commit/7303a90f4916dcf6f66236d40b8917344c27420a

On other things, I tried to pull in the stdlib changes we made in conda-forge

hmaarrfk commented 6 months ago

hmm the patch has incompatibility issues. i guess given the fact that they already resolved it might be ok to add a note about removing the pin the future.

hmaarrfk commented 6 months ago

I tried to add the patch in https://github.com/conda-forge/onnxruntime-feedstock/pull/118 but maybe i missed one instance.

However, the windows failures are annoying too. not too sure how to resolve them.

cbourjau commented 6 months ago

Thanks for the feedback thus far! Given that 1.18.0 was just released I'll put this one on draft for the time being.

conda-forge / onnxruntime-feedstock

Bump build number #116