Remove NumPy version from pip requirements

conda-forge / onnxruntime-feedstock

A conda-smithy repository for onnxruntime.

BSD 3-Clause "New" or "Revised" License

1 stars 19 forks source link

Remove NumPy version from pip requirements #123

Closed jtilly closed 3 months ago

jtilly commented 3 months ago

Closes #122

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

I'm patching the NumPy version in the pip requirements so that we don't end up with (incorrect) errors when we run pip check.

conda-forge-webservices[bot] commented 3 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

hmaarrfk commented 3 months ago

I'm somewhat interested to see if we can get https://github.com/conda-forge/onnxruntime-feedstock/pull/121 in first.

cbourjau commented 3 months ago

I'm somewhat interested to see if we can get #121 in first.

Either seem ready to go. Any reason for getting #121 landed first? Please note that this PR is somewhat urgent since the issue in question does cause CI breakage already.

hmaarrfk commented 3 months ago

Avoiding yet an other build?

I merged #121. It included the commits from here and enables windows users to take advantage of this great work as well.

Let’s see if the builds pass. Generally speaking

pip check

has been pretty touch and go so I don’t always consider it high priority when it breaks often because it is difficult to coordinate a good solution with upstream.