Add janjagusch as maintainer

conda-forge / onnxruntime-feedstock

A conda-smithy repository for onnxruntime.

BSD 3-Clause "New" or "Revised" License

1 stars 20 forks source link

Add janjagusch as maintainer #13

Closed janjagusch closed 3 years ago

janjagusch commented 3 years ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Added janjagusch as recipe maintainer
Fixed jinja template to use {{ version }} instead of hardcoded 1.7.2
Bumped version to 1.8.0

Closes #12

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

janjagusch commented 3 years ago

@conda-forge-admin, please rerender

xhochy commented 3 years ago

@janjagusch If you want to rebase the patch, my current workflow is currently:

Comment out the patch in the meta.yaml
Add an exit 1 at the top of build.sh
Start a build using conda mambabuild
When it fails, cd into the …/work directory
In the …/work directory run source build_env_setup.sh && git init . && git add . && git commit -am "Inital commit"
Apply the patch using git am <patch> and fix the conflicts
Re-export the patch using git format-patch HEAD^1

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

xhochy commented 3 years ago

The eigen hash fails but as this is only to hand over a bit of maintenance we don't need green builds.