onnxruntime v1.9.0 - Githubissues

conda-forge / onnxruntime-feedstock

A conda-smithy repository for onnxruntime.

BSD 3-Clause "New" or "Revised" License

1 stars 19 forks source link

onnxruntime v1.9.0 #16

Closed garymm closed 2 years ago

garymm commented 2 years ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

garymm commented 2 years ago

@xhochy this is not working just yet. The build of onnxruntime fails and I'm not familiar enough with CMake or the onnxruntime build to know why. If you have any suggestions please let me know.

garymm commented 2 years ago

OK, I got it to build locally on Linux. Hopefully all the other variants pass as well.

garymm commented 2 years ago

@xhochy all pipelines passed! Kindly review when you're able. This is my first conda-forge PR so let me know if I did something wrong.

Also I'm trying to upstream the patch so we can remove it in the next version: https://github.com/microsoft/onnxruntime/pull/9181

xhochy commented 2 years ago

Massive Thanks, this looks pretty good!