Drop libprotobuf runtime dependency

conda-forge / onnxruntime-feedstock

A conda-smithy repository for onnxruntime.

BSD 3-Clause "New" or "Revised" License

1 stars 19 forks source link

Drop libprotobuf runtime dependency #40

Closed jtilly closed 2 years ago

jtilly commented 2 years ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

In #6 we started linking against protobuf statically, but we kept the protobuf runtime dependency. Now that the global protobuf pinning is 3.20 but the onnxruntime only supports 3.19, the protobuf runtime dependency makes onnxruntime incompatible with many new package builds. With this PR, I'm dropping the protobuf runtime dependency, because I don't think it serves any purpose. Please correct me if I'm wrong.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

requirements: build: libprotobuf=3.19.1 must contain a space between the name and the pin, i.e. libprotobuf =3.19.1
requirements: host: libprotobuf=3.19.1 must contain a space between the name and the pin, i.e. libprotobuf =3.19.1
requirements: host: libprotobuf-static=3.19.1 must contain a space between the name and the pin, i.e. libprotobuf-static =3.19.1

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.