search

conda-forge / onnxruntime-feedstock

A conda-smithy repository for onnxruntime.
BSD 3-Clause "New" or "Revised" License
1 stars 19 forks source link

Rebuild for libprotobuf321 #43

Closed regro-cf-autotick-bot closed 2 years ago

regro-cf-autotick-bot commented 2 years ago

This PR has been triggered in an effort to update libprotobuf321.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/2940799597, please use this URL for debugging.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

h-vetinari commented 2 years ago

Note that the recipe still has a hard pin for libprotobuf 3.19, so this PR is a "lie" (and so was #41).

xhochy commented 2 years ago

We can close this, as we're statically linking there is no problem with having a different pin in the recipe.

h-vetinari commented 2 years ago

We can close this, as we're statically linking there is no problem with having a different pin in the recipe.

As I had to find out recently, that's only true for shared builds based on those static libs (which is fine because this feedstock is building shared), not for static ones. Just something to keep in mind if this recipe ever builds for windows.

xhochy commented 2 years ago

I'm aware of that. That's usually the case, only shared libs open up a new "context".

h-vetinari commented 2 years ago

I'm aware of that. That's usually the case, only shared libs open up a new "context".

Yeah, I don't doubt that you know. But (presumably) not only you will see this, and I thought I'd try to diffuse some painfully earned knowledge. 😅