Update v1.14.1 - Githubissues

cbourjau commented 1 year ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

This is a PR for updating onnxruntime to the latest version 1.14.1. It is based on #50

There are currently a few issues with this PR:

[ ] This build is impure. See https://github.com/microsoft/onnxruntime/pull/13523 for more details. In short cmake is downloading dependencies itself via FetchContent. This behavior could be overwritten by explicitly downloading the dependencies named in cmake/deps.txt and passing them through via the cmake cli option -DFETCHCONTENT_SOURCE_DIR_<upper-case-package-name>.
[x] ~~Among the downloaded dependencies is protobuf. We probably have to fix at least this one.~~
[x] ~~The package builds but the packaging step fails.~~

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

xhochy commented 1 year ago

Among the downloaded dependencies is protobuf. We probably have to fix at least this one.

This is also why the build fails.

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

Failed to even lint the recipe, probably because of a conda-smithy bug :cry:. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

cbourjau commented 1 year ago

@conda-forge-admin, please rerender

xhochy commented 1 year ago

@conda-forge-admin, please rerender

cbourjau commented 1 year ago

Not patching the dependencies at least has the benefit that it makes future updates easier.

conda-forge / onnxruntime-feedstock