search

conda-forge / onnxruntime-feedstock

A conda-smithy repository for onnxruntime.
BSD 3-Clause "New" or "Revised" License
1 stars 19 forks source link

onnxruntime v1.15.0 #58

Closed regro-cf-autotick-bot closed 1 year ago

regro-cf-autotick-bot commented 1 year ago

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with code>@conda-forge-admin,</codeplease add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Pending Dependency Version Updates

Here is a list of all the pending dependency version updates for this repo. Please double check all dependencies before merging.

Name Upstream Version Current Version
protobuf 23.1 Anaconda-Server Badge

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: false to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis by source code inspection shows a discrepancy between it and the the package's stated requirements in the meta.yaml.

Packages found by source code inspection but not in the meta.yaml:

Packages found in the meta.yaml but not found by source code inspection:

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/5075449501, please use this URL for debugging.

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

jtilly commented 1 year ago

osx builds are failing with

...
2023-05-26T08:32:33.5113660Z [297/1197] Building CXX object _deps/flatbuffers-build/CMakeFiles/flatc.dir/src/idl_gen_go.cpp.o
2023-05-26T08:32:39.8154230Z [298/1197] Building CXX object _deps/flatbuffers-build/CMakeFiles/flatc.dir/src/idl_gen_java.cpp.o
2023-05-26T08:32:52.4741240Z [299/1197] Building CXX object _deps/flatbuffers-build/CMakeFiles/flatc.dir/src/idl_gen_php.cpp.o
2023-05-26T08:32:54.6929510Z [300/1197] Building CXX object _deps/flatbuffers-build/CMakeFiles/flatc.dir/src/idl_gen_kotlin.cpp.o
2023-05-26T08:32:55.5210900Z [301/1197] Building CXX object _deps/flatbuffers-build/CMakeFiles/flatc.dir/src/idl_gen_lobster.cpp.o
2023-05-26T08:32:56.1095370Z [302/1197] Building CXX object _deps/flatbuffers-build/CMakeFiles/flatc.dir/src/idl_gen_js_ts.cpp.o
2023-05-26T08:32:59.2502100Z [303/1197] Building CXX object _deps/flatbuffers-build/CMakeFiles/flatc.dir/src/idl_gen_python.cpp.o
2023-05-26T08:33:05.6305320Z [304/1197] Building CXX object _deps/flatbuffers-build/CMakeFiles/flatc.dir/src/idl_gen_rust.cpp.o
2023-05-26T08:33:05.6365870Z FAILED: _deps/flatbuffers-build/CMakeFiles/flatc.dir/src/idl_gen_rust.cpp.o 
2023-05-26T08:33:05.6420070Z $BUILD_PREFIX/bin/x86_64-apple-darwin13.4.0-clang++ -DEIGEN_MPL2_ONLY -DFLATBUFFERS_LOCALE_INDEPENDENT=0 -DORT_ENABLE_STREAM -I$SRC_DIR/build-ci/Release/_deps/flatbuffers-src/include -I$SRC_DIR/build-ci/Release/_deps/flatbuffers-src/grpc -march=core2 -mtune=haswell -mssse3 -ftree-vectorize -fPIC -fPIE -fstack-protector-strong -O2 -pipe -stdlib=libc++ -fvisibility-inlines-hidden -fmessage-length=0 -isystem $PREFIX/include -fdebug-prefix-map=$SRC_DIR=/usr/local/src/conda/onnxruntime-1.15.0 -fdebug-prefix-map=$PREFIX=/usr/local/src/conda-prefix -ffunction-sections -fdata-sections -fvisibility=hidden -fvisibility-inlines-hidden -fstack-protector-strong -DCPUINFO_SUPPORTED -std=c++11 -stdlib=libc++ -Wall -pedantic -Werror -Wextra -Wno-unused-parameter -O3 -DNDEBUG -std=gnu++17 -arch x86_64 -isysroot /Applications/Xcode_13.2.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk -mmacosx-version-min=10.14 -fPIE -Wold-style-cast -MD -MT _deps/flatbuffers-build/CMakeFiles/flatc.dir/src/idl_gen_rust.cpp.o -MF _deps/flatbuffers-build/CMakeFiles/flatc.dir/src/idl_gen_rust.cpp.o.d -o _deps/flatbuffers-build/CMakeFiles/flatc.dir/src/idl_gen_rust.cpp.o -c $SRC_DIR/build-ci/Release/_deps/flatbuffers-src/src/idl_gen_rust.cpp
2023-05-26T08:33:05.6518800Z $SRC_DIR/build-ci/Release/_deps/flatbuffers-src/src/idl_gen_rust.cpp:409:12: error: variable 'i' set but not used [-Werror,-Wunused-but-set-variable]
2023-05-26T08:33:05.6592970Z     size_t i = 0;
2023-05-26T08:33:05.6694580Z            ^
2023-05-26T08:33:05.6796350Z 1 error generated.
2023-05-26T08:33:08.3714150Z [305/1197] Building CXX object _deps/flatbuffers-build/CMakeFiles/flatc.dir/src/idl_gen_fbs.cpp.o
2023-05-26T08:33:08.6438690Z [306/1197] Building CXX object _deps/flatbuffers-build/CMakeFiles/flatc.dir/src/idl_gen_lua.cpp.o
2023-05-26T08:33:08.8134550Z [307/1197] Building CXX object _deps/flatbuffers-build/CMakeFiles/flatc.dir/src/idl_gen_grpc.cpp.o
2023-05-26T08:33:09.8725880Z [308/1197] Building CXX object _deps/flatbuffers-build/CMakeFiles/flatc.dir/src/idl_gen_json_schema.cpp.o
2023-05-26T08:33:09.8730900Z ninja: build stopped: subcommand failed.
2023-05-26T08:33:09.8784150Z Traceback (most recent call last):
2023-05-26T08:33:09.8786010Z   File "/Users/runner/miniforge3/conda-bld/onnxruntime_1685089113421/work/tools/ci_build/build.py", line 2599, in <module>
2023-05-26T08:33:09.8793130Z     sys.exit(main())
2023-05-26T08:33:09.8794280Z   File "/Users/runner/miniforge3/conda-bld/onnxruntime_1685089113421/work/tools/ci_build/build.py", line 2495, in main
2023-05-26T08:33:09.8803080Z     build_targets(args, cmake_path, build_dir, configs, num_parallel_jobs, args.target)
2023-05-26T08:33:09.8804500Z   File "/Users/runner/miniforge3/conda-bld/onnxruntime_1685089113421/work/tools/ci_build/build.py", line 1434, in build_targets
2023-05-26T08:33:09.8806550Z     run_subprocess(cmd_args, env=env)
2023-05-26T08:33:09.8810520Z   File "/Users/runner/miniforge3/conda-bld/onnxruntime_1685089113421/work/tools/ci_build/build.py", line 781, in run_subprocess
2023-05-26T08:33:09.8811600Z     return run(*args, cwd=cwd, capture_stdout=capture_stdout, shell=shell, env=my_env)
2023-05-26T08:33:09.8812680Z   File "/Users/runner/miniforge3/conda-bld/onnxruntime_1685089113421/work/tools/python/util/run.py", line 49, in run
2023-05-26T08:33:09.8813830Z     completed_process = subprocess.run(
2023-05-26T08:33:09.8814650Z   File "/Users/runner/miniforge3/conda-bld/onnxruntime_1685089113421/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/lib/python3.10/subprocess.py", line 526, in run
2023-05-26T08:33:09.9654700Z     raise CalledProcessError(retcode, process.args,
2023-05-26T08:33:09.9656090Z subprocess.CalledProcessError: Command '['/Users/runner/miniforge3/conda-bld/onnxruntime_1685089113421/_build_env/bin/cmake', '--build', 'build-ci/Release', '--config', 'Release']' returned non-zero exit status 1.
2023-05-26T08:33:11.3736840Z Traceback (most recent call last):
2023-05-26T08:33:11.3738070Z   File "/Users/runner/miniforge3/bin/conda-mambabuild", line 10, in <module>
2023-05-26T08:33:11.3739240Z     sys.exit(main())
2023-05-26T08:33:11.3740400Z   File "/Users/runner/miniforge3/lib/python3.10/site-packages/boa/cli/mambabuild.py", line 256, in main
2023-05-26T08:33:11.3768900Z     call_conda_build(action, config)
2023-05-26T08:33:11.3770140Z   File "/Users/runner/miniforge3/lib/python3.10/site-packages/boa/cli/mambabuild.py", line 228, in call_conda_build
2023-05-26T08:33:11.3771650Z     result = api.build(
2023-05-26T08:33:11.3772430Z   File "/Users/runner/miniforge3/lib/python3.10/site-packages/conda_build/api.py", line 180, in build
2023-05-26T08:33:11.3788140Z     return build_tree(
2023-05-26T08:33:11.3788810Z   File "/Users/runner/miniforge3/lib/python3.10/site-packages/conda_build/build.py", line 3078, in build_tree
2023-05-26T08:33:11.3798660Z     packages_from_this = build(metadata, stats,
2023-05-26T08:33:11.3799260Z   File "/Users/runner/miniforge3/lib/python3.10/site-packages/conda_build/build.py", line 2198, in build
2023-05-26T08:33:11.3804060Z     utils.check_call_env(cmd, env=env, rewrite_stdout_env=rewrite_env,
2023-05-26T08:33:11.3804880Z   File "/Users/runner/miniforge3/lib/python3.10/site-packages/conda_build/utils.py", line 451, in check_call_env
2023-05-26T08:33:11.3809140Z     return _func_defaulting_env_to_os_environ("call", *popenargs, **kwargs)
2023-05-26T08:33:11.3810340Z   File "/Users/runner/miniforge3/lib/python3.10/site-packages/conda_build/utils.py", line 427, in _func_defaulting_env_to_os_environ
2023-05-26T08:33:11.3812210Z     raise subprocess.CalledProcessError(proc.returncode, _args)
2023-05-26T08:33:11.3813310Z subprocess.CalledProcessError: Command '['/bin/bash', '-o', 'errexit', '/Users/runner/miniforge3/conda-bld/onnxruntime_1685089113421/work/conda_build.sh']' returned non-zero exit status 1.
2023-05-26T08:33:18.4251320Z ##[error]Bash exited with code '1'.
2023-05-26T08:33:18.4297680Z ##[section]Finishing: Run OSX build

The -Werror flag is not helping.

I think this flag is coming from flatbuffers, but I'm not sure why this hasn't bothered us before and/or why it's not an issue for the osx builds in https://github.com/microsoft/onnxruntime.

cbourjau commented 1 year ago

I am not sure why this didn't come up earlier either. There were some minor changes in the cmake files of onnxruntime in the range v1.14.1..v1.15.0 which tangentially touched on flatbuffers, but nothing that would be an obvious candidate for this change in behavior. In any case it looks like flatbuffers is setting -Werror based on the compiler used https://github.com/google/flatbuffers/blob/v1.12.0/CMakeLists.txt#L215 which may explain the difference between Linux and OSX.

My hope right now is that we simply don't need flatc. I'm trying that out right now.

cbourjau commented 1 year ago

Not building flatc did the trick!

cbourjau commented 1 year ago

@janjagusch @jtilly do you see any remaining issues with this PR?