conda-forge / onnxruntime-feedstock

A conda-smithy repository for onnxruntime.
BSD 3-Clause "New" or "Revised" License
1 stars 19 forks source link

Add running the testsuite step on non-Windows platforms #62

Closed traversaro closed 1 year ago

traversaro commented 1 year ago

Porting something that I did in https://github.com/conda-forge/onnxruntime-feedstock/pull/56 for Windows, as I think it can be useful to catch eventual regression in the packaging process.

Checklist

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

traversaro commented 1 year ago

On macOS there is a failure of the InferenceSessionTests.InterThreadPoolWithDenormalAsZero test:

2023-06-22T15:08:41.4982140Z 1: [ RUN      ] InferenceSessionTests.InterThreadPoolWithDenormalAsZero
2023-06-22T15:08:41.4994450Z 1: 2023-06-22 15:08:41.499779 [V:onnxruntime:inter_thread_pool_denormal_as_zero, sequential_executor.cc:534 ExecuteThePlan] Number of streams: 1
2023-06-22T15:08:41.4995350Z 1: 2023-06-22 15:08:41.499818 [V:onnxruntime:inter_thread_pool_denormal_as_zero, sequential_executor.cc:518 ExecuteKernel] stream 0 launch kernel with idx 0
2023-06-22T15:08:41.4996690Z 1: $SRC_DIR/onnxruntime/test/framework/inference_session_test.cc:2847: Failure
2023-06-22T15:08:41.4997580Z 1: Expected equality of these values:
2023-06-22T15:08:41.4998860Z 1:   f
2023-06-22T15:08:41.5002230Z 1:     Which is: 1.99999987e-38
2023-06-22T15:08:41.5003240Z 1:   (set_denormal_as_zero) ? 0.0f : denormal_float * 2
2023-06-22T15:08:41.5004100Z 1:     Which is: 0
2023-06-22T15:08:41.5004940Z 1: $SRC_DIR/onnxruntime/test/framework/inference_session_test.cc:2847: Failure
2023-06-22T15:08:41.5005840Z 1: Expected equality of these values:
2023-06-22T15:08:41.5006630Z 1:   f
2023-06-22T15:08:41.5008000Z 1:     Which is: 1.99999987e-38
2023-06-22T15:08:41.5008830Z 1:   (set_denormal_as_zero) ? 0.0f : denormal_float * 2
2023-06-22T15:08:41.5009650Z 1:     Which is: 0
2023-06-22T15:08:41.5010470Z 1: $SRC_DIR/onnxruntime/test/framework/inference_session_test.cc:2847: Failure
2023-06-22T15:08:41.5011310Z 1: Expected equality of these values:
2023-06-22T15:08:41.5012110Z 1:   f
2023-06-22T15:08:41.5012900Z 1:     Which is: 1.99999987e-38
2023-06-22T15:08:41.5013830Z 1:   (set_denormal_as_zero) ? 0.0f : denormal_float * 2
2023-06-22T15:08:41.5014680Z 1:     Which is: 0
2023-06-22T15:08:41.5015540Z 1: $SRC_DIR/onnxruntime/test/framework/inference_session_test.cc:2847: Failure
2023-06-22T15:08:41.5016440Z 1: Expected equality of these values:
2023-06-22T15:08:41.5017300Z 1:   f
2023-06-22T15:08:41.5018090Z 1:     Which is: 1.99999987e-38
2023-06-22T15:08:41.5018870Z 1:   (set_denormal_as_zero) ? 0.0f : denormal_float * 2
2023-06-22T15:08:41.5020010Z 1:     Which is: 0
2023-06-22T15:08:41.5020840Z 1: $SRC_DIR/onnxruntime/test/framework/inference_session_test.cc:2847: Failure
2023-06-22T15:08:41.5021680Z 1: Expected equality of these values:
2023-06-22T15:08:41.5022470Z 1:   f
2023-06-22T15:08:41.5024880Z 1:     Which is: 1.99999987e-38
2023-06-22T15:08:41.5025720Z 1:   (set_denormal_as_zero) ? 0.0f : denormal_float * 2
2023-06-22T15:08:41.5026540Z 1:     Which is: 0
2023-06-22T15:08:41.5030350Z 1: $SRC_DIR/onnxruntime/test/framework/inference_session_test.cc:2847: Failure
2023-06-22T15:08:41.5031450Z 1: Expected equality of these values:
2023-06-22T15:08:41.5032290Z 1:   f
2023-06-22T15:08:41.5033200Z 1:     Which is: 1.99999987e-38
2023-06-22T15:08:41.5034120Z 1:   (set_denormal_as_zero) ? 0.0f : denormal_float * 2
2023-06-22T15:08:41.5035090Z 1:     Which is: 0
2023-06-22T15:08:41.5037550Z 1: $SRC_DIR/onnxruntime/test/framework/inference_session_test.cc:2847: Failure
2023-06-22T15:08:41.5038540Z 1: Expected equality of these values:
2023-06-22T15:08:41.5039170Z 1:   f
2023-06-22T15:08:41.5039500Z 1:     Which is: 1.99999987e-38
2023-06-22T15:08:41.5039940Z 1:   (set_denormal_as_zero) ? 0.0f : denormal_float * 2
2023-06-22T15:08:41.5040340Z 1:     Which is: 0
2023-06-22T15:08:41.5040740Z 1: $SRC_DIR/onnxruntime/test/framework/inference_session_test.cc:2847: Failure
2023-06-22T15:08:41.5041090Z 1: Expected equality of these values:
2023-06-22T15:08:41.5041430Z 1:   f
2023-06-22T15:08:41.5041870Z 1:     Which is: 1.99999987e-38
2023-06-22T15:08:41.5042190Z 1:   (set_denormal_as_zero) ? 0.0f : denormal_float * 2
2023-06-22T15:08:41.5042500Z 1:     Which is: 0
2023-06-22T15:08:41.5043320Z 1: 2023-06-22 15:08:41.500 onnxruntime_test_all[96353:290026] 2023-06-22 15:08:41.500739 [W:onnxruntime:Default, config_options.cc:45 AddConfigEntry] Config with key [session.set_denormal_as_zero] already exists with value [1]. It will be overwritten
2023-06-22T15:08:41.5044150Z 1: 2023-06-22 15:08:41.502846 [V:onnxruntime:inter_thread_pool_denormal_as_zero, sequential_executor.cc:534 ExecuteThePlan] Number of streams: 1
2023-06-22T15:08:41.5045070Z 1: 2023-06-22 15:08:41.502912 [V:onnxruntime:inter_thread_pool_denormal_as_zero, sequential_executor.cc:518 ExecuteKernel] stream 0 launch kernel with idx 0
2023-06-22T15:08:41.5045560Z 1: [  FAILED  ] InferenceSessionTests.InterThreadPoolWithDenormalAsZero (4 ms)

but apparently it is a known issue: https://github.com/microsoft/onnxruntime/issues/13225 . Probably we can just patch it.

traversaro commented 1 year ago

@conda-forge/onnxruntime The PR is ready for review. I did not bumped the build number as the modifications proposed in the PR do not change the output packages.

traversaro commented 1 year ago

Thanks @jtilly!