conda-forge / openblas-feedstock

A conda-smithy repository for openblas.
BSD 3-Clause "New" or "Revised" License
9 stars 39 forks source link

openblas v0.3.19 #130

Closed regro-cf-autotick-bot closed 2 years ago

regro-cf-autotick-bot commented 2 years ago

It is very likely that the current package version for this feedstock is out of date. Notes for merging this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version. Checklist before merging this PR:
    • [ ] Dependencies have been updated if changed: see upstream
    • [ ] Tests have passed
    • [ ] Updated license if changed and license_file is packaged

Note that the bot will stop issuing PRs if more than 3 Version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.

NEW: If you want these PRs to be merged automatically, make an issue with code>@conda-forge-admin,</codeplease add bot automerge in the title and merge the resulting PR. This command will add our new bot automerge feature to your feedstock!

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable. Finally, feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/1599611932, please use this URL for debugging

Here is a list of all the pending dependencies (and their versions) for this repo. Please double check all dependencies before merging.

Name Upstream Version Current Version
ctng-compilers 11.2.0 Anaconda-Server Badge
openblas 0.3.19 Anaconda-Server Badge

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: false to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis of the source code shows a discrepancy between the library's imports and the package's stated requirements in the meta.yaml.

Packages found by inspection but not in the meta.yaml:

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

h-vetinari commented 2 years ago

So flang is definitely in the environment (and on the PATH), but not being found anymore as before. So I'm puzzled where this issue is coming from:

-- The Fortran compiler identification is unknown
CMake Error at cmake/f_check.cmake:27 (enable_language):
  The CMAKE_Fortran_COMPILER:

    flang

  is not a full path and was not found in the PATH.

  Tell CMake where to find the compiler by setting either the environment
  variable "FC" or the CMake cache entry CMAKE_Fortran_COMPILER to the full
  path to the compiler, or to the compiler name if it is in the PATH.
h-vetinari commented 2 years ago

@isuruf, any idea why flang isn't being detected anymore here?

h-vetinari commented 2 years ago

Ping @conda-forge/flang - anything changed with the cmake detection recently? The recipe is not working as before...

ngam commented 2 years ago

@h-vetinari did you look upstream? I saw some related complaints but not sure if they're directly related. Maybe gotta replicate the edit at the start of build.sh in the windows build?


# Fix ctest not automatically discovering tests
LDFLAGS=$(echo "${LDFLAGS}" | sed "s/-Wl,--gc-sections//g")

# See this workaround
# ( https://github.com/xianyi/OpenBLAS/issues/818#issuecomment-207365134 ).
CF="${CFLAGS}"
unset CFLAGS

(full disclosure: I have no idea how windows works at all)

h-vetinari commented 2 years ago

My gawd, I forgot how slow the PPC builds are in emulation here (~4h). Combined with azure's insistence to delete logs of cancelled runs, I'm gonna skip them for the time being. In the meantime, this was the windows error

CMake Error at D:/bld/openblas_1644038885032/_build_env/Library/share/cmake-3.21/Modules/CMakeTestCCompiler.cmake:69 (message):
-- Check for working C compiler: D:/bld/openblas_1644038885032/_build_env/Library/bin/clang-cl.exe - broken
  The C compiler

    "D:/bld/openblas_1644038885032/_build_env/Library/bin/clang-cl.exe"

  is not able to compile a simple test program.

  It fails with the following output:

    Change Dir: D:/bld/openblas_1644038885032/work/build/CMakeFiles/CMakeTmp

    Run Build Command(s):jom -f Makefile /nologo cmTC_95f9d\fast && jom: parallel job execution disabled for Makefile
        D:\bld\openblas_1644038885032\_build_env\Library\bin\jom.exe  -f CMakeFiles\cmTC_95f9d.dir\build.make /nologo -L CMakeFiles\cmTC_95f9d.dir\build
    Building C object CMakeFiles/cmTC_95f9d.dir/testCCompiler.c.obj
        D:\bld\openblas_1644038885032\_build_env\Library\bin\clang-cl.exe @C:\Users\VSSADM~1\AppData\Local\Temp\testCCompiler.c.obj.4012.15.jom
    Linking C executable cmTC_95f9d.exe
        D:\bld\openblas_1644038885032\_build_env\Library\bin\cmake.exe -E vs_link_exe --intdir=CMakeFiles\cmTC_95f9d.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100220~1.0\x64\rc.exe --mt=D:\bld\openblas_1644038885032\_build_env\Library\bin\llvm-mt.exe --manifests -- C:\PROGRA~1\LLVM\bin\lld-link.exe /nologo @CMakeFiles\cmTC_95f9d.dir\objects1.rsp @C:\Users\VSSADM~1\AppData\Local\Temp\cmTC_95f9d.exe.4012.93.jom
    MT: command "D:\bld\openblas_1644038885032\_build_env\Library\bin\llvm-mt.exe /nologo /manifest CMakeFiles\cmTC_95f9d.dir/intermediate.manifest /out:CMakeFiles\cmTC_95f9d.dir/embed.manifest /notify_update" failed (exit code 0x1) with the following output:
    llvm-mt: error: no libxml2
    llvm-mt: ignoring unsupported 'notify_update' option
    jom: D:\bld\openblas_1644038885032\work\build\CMakeFiles\CMakeTmp\CMakeFiles\cmTC_95f9d.dir\build.make [cmTC_95f9d.exe] Error 2
    jom: D:\bld\openblas_1644038885032\work\build\CMakeFiles\CMakeTmp\Makefile [cmTC_95f9d\fast] Error 2

... hence, adding libxml2.

h-vetinari commented 2 years ago

This runs into https://github.com/conda-forge/llvmdev-feedstock/issues/117, since the fix for that only happened for llvmdev 11.1, but flang 11 was only built for 11.0. See https://github.com/conda-forge/flang-feedstock/issues/21