conda-forge / openblas-feedstock

A conda-smithy repository for openblas.
BSD 3-Clause "New" or "Revised" License
9 stars 38 forks source link

Fix behavior on Apple Silicon #141

Closed hoechenberger closed 1 year ago

hoechenberger commented 1 year ago

Currently, OpenBLAS is broken on M1 machines and yields incorrect results (see #139).

The fix for that problem will be included in the next release of OpenBLAS, but it's unclear when the release will actually happen.

This means that currently, anyone using this version of OpenBLAS on Apple Silicon may end up with incorrect calculations: effectively, this package is broken on Apple Silicon!

The fix is a simple one-liner. Hence, I propose to "backport" this patch here, and bump the build number.

This change will only affect M1 users; behavior on all other platforms will be unaffected.

Closes #139

Checklist

conda-forge-linter commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

hoechenberger commented 1 year ago

I am not sure why the Travis build time out.

hoechenberger commented 1 year ago

Aside from Travis, all CI systems come back green.

hoechenberger commented 1 year ago

@conda-forge-admin, please restart ci

hoechenberger commented 1 year ago

I'd go so far as to ask the feedstock maintainers to mark existing arm64 builds as broken / remove them from anaconda.org unless we manage to get this PR merged ASAP (in which case one could always just ask users to simply use the latest build)

h-vetinari commented 1 year ago

I'd go so far as to ask the feedstock maintainers to mark existing arm64 builds as broken / remove them from anaconda.org unless we manage to get this PR merged ASAP (in which case one could always just ask users to simply use the latest build)

Fine by me - I wasn't aware of the urgency. I had restarted travis manually already, but since osx-arm isn't built on travis, I don't see a reason why we have to wait.

h-vetinari commented 1 year ago

Since this was green on azure without any changes since then, I'm merging.

hoechenberger commented 1 year ago

Thank you so much, @h-vetinari!

As soon as this hits the CDN, @larsoner and I will start some serious testing to confirm everything works as expected.

We'll report back with any success stories & problem reports.

Thanks again for the super swift action!

larsoner commented 1 year ago

Thanks @h-vetinari I'll sleep better at night now knowing all those SVDs won't be silently broken anymore :)