search

conda-forge / openblas-feedstock

A conda-smithy repository for openblas.
BSD 3-Clause "New" or "Revised" License
9 stars 38 forks source link

add libblas symlinks #25

Closed isuruf closed 7 years ago

isuruf commented 7 years ago

Fixes #23

conda-forge-linter commented 7 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

jakirkham commented 7 years ago

Would also need a build number bump.

jakirkham commented 7 years ago

Personally I'm ok with doing something like this. I think I had held off on doing it as we thought people might want to mix BLASes initially, but it has become clear after the brief disruption of having NumPy use OpenBLAS and SciPy use MKL that this is really not feasible as one will get crashes. Not sure if there are any other downsides to this.

isuruf commented 7 years ago

@jakirkham, I opened an alternative PR https://github.com/conda-forge/blas-feedstock/pull/7. Problem with that is that there is a version bump and all conda-forge packages pin the blas package with the exact version.

jakirkham commented 7 years ago

Changes like these seem to require knowledge of the specific package. So it would be better for these details to live in the packages that implement them IMHO.

FWIW there has been discussion at OpenBLAS about including libraries like these as output of the build. ( https://github.com/xianyi/OpenBLAS/issues/296 ) So if we have to change it in the future, it would be better if we just change the openblas package and not the blas package.

jakirkham commented 7 years ago

LGTM. Other thoughts @conda-forge/openblas?

isuruf commented 7 years ago

ping @conda-forge/openblas

ocefpaf commented 7 years ago

Thanks @isuruf!

isuruf commented 7 years ago

Thanks for the reviews and the merge