search

conda-forge / openblas-feedstock

A conda-smithy repository for openblas.
BSD 3-Clause "New" or "Revised" License
9 stars 38 forks source link

Release 0.3.0 #44

Closed jakirkham closed 6 years ago

jakirkham commented 6 years ago

Builds the very recent (and long awaited) release of OpenBLAS, 0.3.0. Likely still needs work, but putting it up to get that work and discussion started.

conda-forge-linter commented 6 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

jakirkham commented 6 years ago

Looks like the CIs need some massaging here.

CircleCI is complaining about the build being too quiet. There is a no_output_timeout parameter which we can set to skirt this. We might consider setting this for all feedstocks ( https://github.com/conda-forge/conda-smithy/issues/784 ).

Travis CI is complaining about the build being too noisy. Most of the warnings are about fabs being used when fabsl would be more appropriate. We could fix this with a patch or silence the warning. Some discussion about this in issue ( https://github.com/xianyi/OpenBLAS/issues/1357 ).

Surprisingly AppVeyor seems content even after dropping ~10 patches, which is amazing. Good work everyone that has been involved on the Windows build.

isuruf commented 6 years ago

Travis CI is complaining about the build being too noisy.

No, travis-ci is also failing because of timeouts. New openblas versions has fewer warnings and hence no output.

jakirkham commented 6 years ago

Yep. You’re right. I misread.

jakirkham commented 6 years ago

Looks like adding logging information caused Travis CI to go over. 😩

Fortunately CircleCI seemed to work with this change. 🎉

Given this, am just switching the macOS builder to CircleCI. Not going to mess around with Travis CI's constraints on this one again. Doing this once when adding this recipe was enough for me.

jakirkham commented 6 years ago

Would note there is a .dev in the SONAME, which is a little odd. ( https://github.com/xianyi/OpenBLAS/issues/1576 )

jakirkham commented 6 years ago

Thoughts @conda-forge/openblas?

jschueller commented 6 years ago

+1, what's the plan to update all the packages that link to openblas now, old school or conda 3 ?

jakirkham commented 6 years ago

Move to conda-build 3 as well. We may also take the time to fix blas as we rebuild things.

xref: https://github.com/conda-forge/blas-feedstock/pull/12

jakirkham commented 6 years ago

Other thoughts?

jakirkham commented 6 years ago

Ping?

jakirkham commented 6 years ago

Anything else?

jakirkham commented 6 years ago

Thanks all :)