search

conda-forge / openblas-feedstock

A conda-smithy repository for openblas.
BSD 3-Clause "New" or "Revised" License
9 stars 38 forks source link

Split out static library #69

Closed jcrist closed 5 years ago

jcrist commented 5 years ago

The static library for openblas is quite large, and won't be needed by most users. 

$ du -hc /Users/jcrist/miniconda3/envs/testenv/lib/libopenblasp-r0.3.6.a
 62M    /Users/jcrist/miniconda3/envs/testenv/lib/libopenblasp-r0.3.6.a
 62M    total

It would be good to split it out into a separate package.

Defaults ships this as libopenblas-static (see https://github.com/conda-forge/openblas-feedstock/issues/54#issuecomment-435437772)

ocefpaf commented 5 years ago

I'm :+1: on splitting. @isuruf you are our blas expert, what do you think?

isuruf commented 5 years ago

Sure. I'd just leave the static library in openblas along with the headers and split the dynamic libraries into libopenblas and make blas-feedstock depend on libopenblas.

ocefpaf commented 5 years ago

I believe that is similar to what AR is doing here, right?

https://github.com/AnacondaRecipes/openblas-feedstock/blob/master/recipe/meta.yaml

ocefpaf commented 5 years ago

PS: we have two failing PRs trying to sync with AR #55 and #52, time for a thrid one :smile:

isuruf commented 5 years ago

I don't find it useful to have 4 packages there. I'd just have libopenblas and openblas (which is going to be openblas, libopenblas-static, openblas-devel in defaults merged together)

ocefpaf commented 5 years ago

While I agree with you it would be nice to know why @mingwandroid chose to split it that way and the advantages of staying in sync (interoperability of recipes is nice to have).

mingwandroid commented 5 years ago

To save space for those who care not for static libraries (nearly everyone).

ocefpaf commented 5 years ago

To save space for those who care not for static libraries (nearly everyone).

@mingwandroid please see the comment about the 4 subpackages in @isuruf's https://github.com/conda-forge/openblas-feedstock/issues/69#issuecomment-496635004.

The static splitting is happening BTW.

mingwandroid commented 5 years ago

I prefer openblas be an empty metapackage as it stands to be honest with you. It's there for old recipes, so that their dependencies on openblas still work as expected. I believe my split is more logical too, but overall I don't mind and I think we'd resync to whatever is decided as best.

ocefpaf commented 5 years ago

Done in #70.

isuruf commented 5 years ago

Needs https://github.com/conda-forge/blas-feedstock/issues/31 to make use of libopenblas