Add libopenblas.so without suffix

massich commented 4 years ago

Checklist

[x] Used a fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
~[ ] Reset the build number to 0 (if the version changed)~
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

Failed to even lint the recipe, probably because of a conda-smithy bug :cry:. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

massich commented 4 years ago

@conda-forge-admin please rerender.

isuruf commented 4 years ago

This is not correct. The .so should go in the openblas output and not libopenblas output

massich commented 4 years ago

I'm trying to run smithy but I get the following error:

~/repos/openblas-feedstock/recipe add_so 49s
(openmeeg-feedstock-test) ❯ conda update conda-smithy -c conda-forge
Collecting package metadata (current_repodata.json): done
Solving environment: done

# All requested packages already installed.

~/repos/openblas-feedstock/recipe add_so
(openmeeg-feedstock-test) ❯ conda smithy recipe-lint .              
Traceback (most recent call last):
  File "/home/sik/miniconda3/envs/openmeeg-feedstock-test/bin/conda-smithy", line 10, in <module>
    sys.exit(main())
  File "/home/sik/miniconda3/envs/openmeeg-feedstock-test/lib/python3.7/site-packages/conda_smithy/cli.py", line 477, in main
    args.subcommand_func(args)
  File "/home/sik/miniconda3/envs/openmeeg-feedstock-test/lib/python3.7/site-packages/conda_smithy/cli.py", line 372, in __call__
    return_hints=True,
  File "/home/sik/miniconda3/envs/openmeeg-feedstock-test/lib/python3.7/site-packages/conda_smithy/lint_recipe.py", line 574, in main
    results, hints = lintify(meta, recipe_dir, conda_forge)
  File "/home/sik/miniconda3/envs/openmeeg-feedstock-test/lib/python3.7/site-packages/conda_smithy/lint_recipe.py", line 392, in lintify
    for requirement in requirements:
TypeError: 'NoneType' object is not iterable

isuruf commented 4 years ago

@massich, https://github.com/conda-forge/conda-smithy/pull/1175

massich commented 4 years ago

@isuruf do you know how to patch it without the help of smithy?

isuruf commented 4 years ago

Edit /home/sik/miniconda3/envs/openmeeg-feedstock-test/lib/python3.7/site-packages/conda_smithy/lint_recipe.py ?

massich commented 4 years ago

any idea why conda-forge-linter is complaining? it passes with conda-smithy (master) passes

~/repos/openblas-feedstock/recipe add_so
(openmeeg-feedstock-test) ❯ conda smithy recipe-lint .        
. is in fine form

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

conda-forge / openblas-feedstock

Add libopenblas.so without suffix #86