Build both pthreads and openmp on linux

conda-forge / openblas-feedstock

A conda-smithy repository for openblas.

BSD 3-Clause "New" or "Revised" License

9 stars 38 forks source link

Build both pthreads and openmp on linux #99

Closed isuruf closed 4 years ago

isuruf commented 4 years ago

Checklist

[ ] Used a fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [36, 37, 63, 64]

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

isuruf commented 4 years ago

@conda-forge-admin, rerender

isuruf commented 4 years ago

Running the following gives an error,

import numpy as np
import numpy.linalg as la

la.det(np.array([[1, 0], [0, 1]]))

libgomp.so.1: error: symbol lookup error: undefined symbol: ompt_start_tool (fatal)

This doesn't happen with GNU's and only with LLVM's.

This PR builds with and without openmp and makes the one without openmp the default.

isuruf commented 4 years ago

Why is the osx build with llvm openmp also not broken?

Don't know.

Did the ABI compatibility change between gnu and llvm?

Not sure either.

isuruf commented 4 years ago

cc @ocefpaf,

By default on Linux, openblas uses pthreads for threading now instead of the previous openmp default. openmp build can be recovered by installing libopenblas=*=*openmp*

bgruening commented 4 years ago

@isuruf we get a coredump with the latest version: https://travis-ci.com/github/lldelisle/pyGenomeTracks/jobs/362129644#L974

libopenblas-0.3.9 seems to work for us. Both versions (also 0.3.10-openmp_h709eae2_2) seems to cause the segfault.

isuruf commented 4 years ago

Please open a different issue.