conda-forge / openconnect-feedstock

A conda-smithy repository for openconnect.
BSD 3-Clause "New" or "Revised" License
1 stars 5 forks source link

OpenConnect v9.01 + osx-arm64 support #6

Closed leofang closed 2 years ago

leofang commented 2 years ago

Checklist

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

leofang commented 2 years ago

@conda-forge-admin, please rerender

leofang commented 2 years ago

Blocked by https://github.com/conda-forge/stoken-feedstock/pull/6.

leofang commented 2 years ago

@conda-forge-admin, please rerender

github-actions[bot] commented 2 years ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/openconnect-feedstock/actions/runs/2401194000.

leofang commented 2 years ago

@conda-forge-admin, please restart ci

leofang commented 2 years ago

Blocked by https://github.com/conda-forge/gnutls-feedstock/pull/24... 😞

leofang commented 2 years ago

@conda-forge-admin, please restart ci

leofang commented 2 years ago

@conda-forge-admin, please rerender

leofang commented 2 years ago

@conda-forge-admin, please rerender

github-actions[bot] commented 2 years ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/openconnect-feedstock/actions/runs/2412073858.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

leofang commented 2 years ago

@conda-forge-admin, please rerender

github-actions[bot] commented 2 years ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/openconnect-feedstock/actions/runs/2412094138.

leofang commented 2 years ago

@conda-forge-admin, please rerender

github-actions[bot] commented 2 years ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/openconnect-feedstock/actions/runs/2412123303.

leofang commented 2 years ago

@conda-forge-admin, please rerender

github-actions[bot] commented 2 years ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/openconnect-feedstock/actions/runs/2412163311.

leofang commented 2 years ago

@conda-forge-admin, please rerender

leofang commented 2 years ago

@conda-forge-admin, please rerender

leofang commented 2 years ago

I verified the osx-arm64 build on my M1. Everything works fine. The only noticeable difference compared to the builds for other platforms, as well as Homebrew's M1 build, is whenever openconnect is launched there's a warning raised:

WARNING: Cannot set locale: No such file or directory

but other than that I can't tell the difference, at least not for now.

@conda-forge/openconnect @stuarteberg this is ready for review 🙂

leofang commented 2 years ago

@conda-forge-admin, please rerender

github-actions[bot] commented 2 years ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/openconnect-feedstock/actions/runs/2412461295.

leofang commented 2 years ago

Note: I believe skip_compile_pyc is the right fix compared to the previous workaround I did. It's needed only when cross-compiling, where the build Python must be used but it can't guarantee the generated pyc can be used in host env.

leofang commented 2 years ago

Friendly nudge @stuarteberg 🙂

leofang commented 2 years ago

@conda-forge/openconnect @conda-forge/core Can anyone help merge this MR? I need this package for M1. Thanks.

leofang commented 2 years ago

Thanks, @hmaarrfk!