Bump version to 4.5.5 - Githubissues

conda-forge / opencv-feedstock

A conda-smithy repository for opencv.

BSD 3-Clause "New" or "Revised" License

65 stars 60 forks source link

Bump version to 4.5.5 #296

Closed traversaro closed 2 years ago

traversaro commented 2 years ago

I tried to use the existing libopencv 4.5.3 package with Visual Studio 2022, but it does not work as the OpenCVConfig.cmake file has some logic that needed to be update explicity for Visual Studio 2022 (see https://github.com/robotology/robotology-superbuild/pull/995#issuecomment-1010144950). As 4.5.5 is the latest release, I updated directly to the last one.

Checklist

[x] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

traversaro commented 2 years ago

Thanks @hmaarrfk for removing the only existing patch, indeed this can be dropped thanks to https://github.com/opencv/opencv/pull/20386 .

hmaarrfk commented 2 years ago

Nice. yeah. tryinf to help with other config when I have time too.

hmaarrfk commented 2 years ago

Seems like we need to add a similar tesseract line for windows. are you able to do that?

traversaro commented 2 years ago

Seems like we need to add a similar tesseract line for windows. are you able to do that?

Done: https://github.com/traversaro/opencv-feedstock/commit/04098806fd6f0e1ba4337504738bcf79b6588c7d .

traversaro commented 2 years ago

@conda-forge-admin, please rerender

traversaro commented 2 years ago

fyi @wolfv @Tobias-Fischer as this could result in requiring rebuild on the RoboStack side.

traversaro commented 2 years ago

This will trigger a new CI, but probably we can remove the file https://github.com/traversaro/opencv-feedstock/blob/patch-2/recipe/20386-SetTotalBytesLimit-one-arg.patch, is that ok for you @hmaarrfk ?

github-actions[bot] commented 2 years ago

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

hmaarrfk commented 2 years ago

I know the windows builds are slow, but thye are often the ones that fail for some random reason. Trying to ensure they pass before breaking things in the system.

github-actions[bot] commented 2 years ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR: