Build a headless opencv version

hmaarrfk commented 1 year ago

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-linter commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

hmaarrfk commented 1 year ago

needs: https://github.com/conda-forge/qt-main-feedstock/pull/100#issuecomment-1383046493

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

If python is a host requirement, it should be a run requirement.

hmaarrfk commented 1 year ago

@conda-forge-admin please rerender

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

hmaarrfk commented 1 year ago

This is mostly really useful for those that want to start testing with qt6

hmaarrfk commented 1 year ago

@conda-forge/opencv thoughts on maintainability are appreciated.

hmaarrfk commented 1 year ago

@conda-forge-admin please rerender

hmaarrfk commented 1 year ago

Sorry it seems like there is still some work to do on windows.

hmaarrfk commented 1 year ago

@conda-forge-admin please rerender

hmaarrfk commented 1 year ago

@conda-forge-admin please rerender

Tobias-Fischer commented 1 year ago

I'm not a maintainer, but overall LGTM, just some minor suggestions.

hmaarrfk commented 1 year ago

@conda-forge-admin please rerender

hmaarrfk commented 1 year ago

@conda-forge-admin please rerender

hmaarrfk commented 1 year ago

@conda-forge-admin please rerender

hmaarrfk commented 1 year ago

I'm not convinced this is the right approach due to increased maintenance burden.

jan-janssen commented 1 year ago

@hmaarrfk What is the recommended approach for pypi packages which depend on opencv-python-headless ? Others like Intel provide such a package https://anaconda.org/intel/opencv-python-headless .

hmaarrfk commented 1 year ago

What is the recommended approach for pypi packages which depend on opencv-python-headless

pip install --no-deps package

is my only recommendation.

I'm not sure. I feel like opencv-python-headless is a workaround from the combined limitations of pypi and opencv. We have different limitations here which make me hesitant to merge something like this.

The main issue with pypi is that one package may depend on opencv-python and the other on opencv-python-headless.

This merge request (as it is) wouldn't make pypi find a locally installed version of opencv-python-headless and thus would not resolve your issue.

I would accept updates to this feedstock that make it look like a opencv-python-headless is installed along side with opencv-python.

Perhaps you can be inspired by:

https://github.com/conda-forge/opencv-feedstock/blob/main/recipe/install_pip_metadata.patch

I would ask that you add alot of skips when developing on the CIs for now. The build matrix for opencv is already quite huge.

jjerphan commented 1 year ago

Hi @hmaarrfk, thank you for this piece of work!

I might be able to help with packaging the equivalent of opencv-headless-python.

Is there a lot of work left? Would you be able to estimate the time it would take to finish it? Can I contribute to your efforts?

hmaarrfk commented 1 year ago

on the coding side, the answer is that it is "done".

the question I have is:

I do not want to use pup I'd strategy of having two packages with different names that end users need to choose which will clash when two of their dependencies choose opposite ones.
GUI support is not built as a plugin for open CV so it must be bundled in the python precompuled library. this is one technical thing that you might be able to submit patches for upstream

if you have ideas on how to deliver it to the wider audience I am glad to hear it.

personally, I see this request as quite niche, and those that require it can likely rebuild opencv using azure's free agents and upload the package to their channel. the package would be called opencv and simply not install the qt aspects for users that subscribe to your channel.

conda-forge / opencv-feedstock

Build a headless opencv version #337