search

conda-forge / opencv-feedstock

A conda-smithy repository for opencv.
BSD 3-Clause "New" or "Revised" License
64 stars 59 forks source link

Rerender 4.5.3 #347

Closed xhochy closed 1 year ago

xhochy commented 1 year ago

As easyocr has a <=4.5.4 pin on OpenCV, I need to rebuild this rather old version. One of the important fixes is that we need to fix the Python 3.10 build strings.

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

hmaarrfk commented 1 year ago

Opencv hasn't been the hardest to migrate. can you reference the issue that stops compilation? Maybe we can help upstream update their version instead?

xhochy commented 1 year ago

It seems the upstream issue has been fixed: https://github.com/JaidedAI/EasyOCR/issues/633

xhochy commented 1 year ago

I will give this a tiny bit more love while a colleague of mine will look into getting rid of the upstream pin.

xhochy commented 1 year ago

@hmaarrfk This has passed and fixes weren't that complicated. OK to merge?

hmaarrfk commented 1 year ago

Cubans ???

I'm going to consider you in charge of this branch. You can merge at will.

hmaarrfk commented 1 year ago

I would prefer if we didn't do automatic "migrations" on this branch.

xhochy commented 1 year ago

I would prefer if we didn't do automatic "migrations" on this branch.

No, I would try to keep this down to the most minimal work possible and hope that it will only have a very short life.