Closed pkgw closed 2 years ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
Seeing the bunch of unaddressed PRs in this feedstock, I'll also volunteer to add myself as a maintainer here.
Windows errors of the form:
%SRC_DIR%\src\test\OpenEXRCoreTest\compression.cpp(484): error C2039: 'min': is not a member of 'std'
Google says that this can be fixed by adding #include <algorithm>
, so I'll try that.
@conda-forge/openexr This is ready for review.
@wolfv @JohanMabille You were the ones that responded for the imath
addition — please let me know if this is OK to merge, or go ahead and do so yourselves?
Checklist
0
(if the version changed)conda-smithy
(Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)There are somewhat substantial API changes in this update, but based on the Announcements here there may be unpatched CVEs for the 2.x series, so I think it makes sense to take the plunge. I have a PR prepared for openexr-python that gets it building (on Linux, at least).