Update to upstream 3.1.4

conda-forge / openexr-feedstock

A conda-smithy repository for openexr.

BSD 3-Clause "New" or "Revised" License

3 stars 11 forks source link

Update to upstream 3.1.4 #22

Closed pkgw closed 2 years ago

pkgw commented 2 years ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

There are somewhat substantial API changes in this update, but based on the Announcements here there may be unpatched CVEs for the 2.x series, so I think it makes sense to take the plunge. I have a PR prepared for openexr-python that gets it building (on Linux, at least).

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

pkgw commented 2 years ago

Seeing the bunch of unaddressed PRs in this feedstock, I'll also volunteer to add myself as a maintainer here.

pkgw commented 2 years ago

Windows errors of the form:

%SRC_DIR%\src\test\OpenEXRCoreTest\compression.cpp(484): error C2039: 'min': is not a member of 'std'

Google says that this can be fixed by adding #include <algorithm>, so I'll try that.

pkgw commented 2 years ago

@conda-forge/openexr This is ready for review.

pkgw commented 2 years ago

@wolfv @JohanMabille You were the ones that responded for the imath addition — please let me know if this is OK to merge, or go ahead and do so yourselves?