search

conda-forge / openh264-feedstock

A conda-smithy repository for openh264.
BSD 3-Clause "New" or "Revised" License
0 stars 9 forks source link

Migrate to Jinja2 compiler syntax #1

Closed regro-cf-autotick-bot closed 6 years ago

regro-cf-autotick-bot commented 6 years ago

This PR was created by the cf-regro-autotick-bot.

The cf-regro-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. It is very likely that the current package version for this feedstock is out of date or needed migration.

List of changes done to the recipe: Renamed build with host Removing toolchain in favour of compiler() Moving pkg-config from host to build Removing pinnings for zlib to use values from conda_build_config.yaml Adding C compiler Adding C++ compiler

If you have recived a Migrate to Jinja2 compiler syntax PR from me recently please close that one and use this one. Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable.

Finally, feel free to drop us a line if there are any issues!

conda-forge-linter commented 6 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

183amir commented 6 years ago

@mariusvniekerk please remove zlib from the requirements:run section and move nasm from host to build. Then, this is good to go.

carlodri commented 6 years ago

@183amir looks like there were quite frequent soname changes in the history of this library: https://abi-laboratory.pro/index.php?view=timeline&l=openh264

it could be wise to introduce the same versioning scheme as in https://github.com/conda-forge/x264-feedstock, and proper pinnings in conda in order to account for such soname changes

183amir commented 6 years ago

I don't think it's necessary to make those complicated changes here too since the soname change is aligned with minor version changes. You can make this recipe similar to https://gitlab.idiap.ch/bob/bob.conda/blob/2fb6e571a760892e2447494cb52944011fbf302f/conda/openh264/meta.yaml

carlodri commented 6 years ago

ok, I think I see your point: historically a bump in soname is always accompanied by a minor version bump, so as long as this happens it is sufficient to pin to x.x. Correct?

183amir commented 6 years ago

yes