don't pull in nnpops on osx or windows

conda-forge / openmm-ml-feedstock

A conda-smithy repository for openmm-ml.

BSD 3-Clause "New" or "Revised" License

0 stars 4 forks source link

don't pull in nnpops on osx or windows #1

Closed mikemhenry closed 2 years ago

mikemhenry commented 2 years ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

noarch packages can't have selectors. If the selectors are necessary, please remove noarch: python.

mikemhenry commented 2 years ago

@conda-forge-admin, please rerender

github-actions[bot] commented 2 years ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/openmm-ml-feedstock/actions/runs/3114788933.

mikemhenry commented 2 years ago

noarch packages can't have selectors. If the selectors are necessary, please remove noarch: python.

Well that answers my question!

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

mikemhenry commented 2 years ago

Looks like 3.10 if failing for OSX and Linux because we don't have 3.10 builds for openmm, which is fine, so I will go ahead and merge this in.

peastman commented 2 years ago

The 8.0 beta does have 3.10 builds. I think we need a proper beta release of this package that is built against the betas of OpenMM and OpenMM-Torch. This also seems to have only built for x86, not ARM.

mikemhenry commented 2 years ago

@peastman This package used to be noarch so I forgot to add the arm builds! I will fix that!

Also I misread the error: package openmm-torch-0.03-py36h110734a_0 requires python_abi 3.6.* *_cp36m, but none of the providers can be installed

It looks like openmm-torch is missing the python 3.10 builds with the main tag, but has them with the openmm_rc tag, so I will need to also rebuild this package where it pulls those in.