pin torchani to 2.2.2 - Githubissues

conda-forge / openmm-ml-feedstock

A conda-smithy repository for openmm-ml.

BSD 3-Clause "New" or "Revised" License

0 stars 4 forks source link

pin torchani to 2.2.2 #5

Closed mikemhenry closed 2 years ago

mikemhenry commented 2 years ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

peastman commented 2 years ago

Though actually, I wonder if we want to make it >2.2.2? For the environment file it's good to pin to a particular version, but an exact pin in the package will make it impossible to install later versions. We just need a version that is late enough to include the bug fix.

peastman commented 2 years ago

Sorry, I meant to say >=2.2.2.

mikemhenry commented 2 years ago

Yes I agree! I didn't check to see if they had a newer version or not, so I was playing it safe, but I don't think we have any reason to believe (until it happens) that a newer version will be problematic.

but an exact pin in the package will make it impossible to install later versions

Yes that can get really tricky to deal with.

github-actions[bot] commented 2 years ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

linter: passed
azure: passed

Thus the PR was passing and merged! Have a great day!